Conversation
aca19eb to
dc50b8a
Compare
|
Just a heads up: 0.23 had to be tagged as breaking before the 0.24 breaking release (which is imminent), since 0.24 will be quite a bit more breaking and we didn't want the features from 0.23 to be held back by 0.24.
|
|
Would be great to merge this if possible. |
greimel
left a comment
There was a problem hiding this comment.
Since arrows is used in tests we need to disallow the old Makie versions I suppose?
|
Unfortunately, tests don't pass, so this can't be merged before the package gets fixed. |
|
Seems the test error is because the stored reference images are in RGB and the newly generated images are in RGBA. Comparing the mixed RGB/RGBA is not handled by ReferenceTests.jl. Could potentially just force conversion to RGB in |
This pull request changes the compat entry for the
Makiepackage from0.21, 0.22to0.21, 0.22, 0.23.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.