Skip to content

CompatHelper: bump compat for Makie to 0.23, (keep existing compat)#213

Merged
hexaeder merged 7 commits intomasterfrom
compathelper/new_version/2025-06-12-01-13-35-616-00230053974
Jun 17, 2025
Merged

CompatHelper: bump compat for Makie to 0.23, (keep existing compat)#213
hexaeder merged 7 commits intomasterfrom
compathelper/new_version/2025-06-12-01-13-35-616-00230053974

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This pull request changes the compat entry for the Makie package from 0.21, 0.22 to 0.21, 0.22, 0.23.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@SimonDanisch SimonDanisch force-pushed the compathelper/new_version/2025-06-12-01-13-35-616-00230053974 branch from aca19eb to dc50b8a Compare June 12, 2025 01:13
@SimonDanisch
Copy link
Copy Markdown
Member

Just a heads up:

0.23 had to be tagged as breaking before the 0.24 breaking release (which is imminent), since 0.24 will be quite a bit more breaking and we didn't want the features from 0.23 to be held back by 0.24.
The breaking changes:

  • Breaking Refactored arrows to solve various issues: #4925
    • Breaking Arrows as a type is deprecated as the recipe has been split up. Use the Makie.ArrowLike conversion trait, Arrows2D or Arrows3D instead.
    • Breaking The arrows!() function is deprecated in favor of arrows2d!() and arrows3d!(). These plot functions differ in how they render arrows and can be used in 2D and 3D interchangeably.
    • Breaking The arrow size now considers all components of the arrow, not just the shaft, changing sizes and alignments.
    • Breaking align no longer accepts :lineend, :tailend, :headstart and :origin. It now only accepts :head, :center, :tail and numbers for fractional alignment. Issues with these alignments not working correctly have been fixed.
    • Breaking Attributes arrowhead, arrowtail, arrowcolor, linecolor, linewidth, arrowsize are deprecated. See ?arrows2d and ?arrows3d or the main docs for replacements.
    • Breaking Attributes linestyle and transform_marker are no longer supported.
    • Breaking Outside of minshaftlength .. maxshaftlength, arrows now scale as a whole instead of just their shaft.
    • Breaking 3D Arrows now try to scale to a size appropriate to the given data. This can be turned off by setting markerscale to a static number.
    • Arrows are now split into a tail, shaft and head, allowing for double-headed arrows.
    • 2D arrows are now based on poly, fixing self-overlap issues with transparent arrows.
    • 3D arrow tips, or more generally the new GeometryBasics.Cone, render with much smoother shading.
    • argmode = :endpoint has been added to allow constructing arrows with a start and end point instead of a start point and a direction.
    • Arrows now work correctly with colorrange, alpha, etc.
    • Transforms (e.g. log or rotate!(plot, ...)) now only affect the start and end points of arrows, rather than their components. This fixes

@thchr
Copy link
Copy Markdown
Contributor

thchr commented Jun 16, 2025

Would be great to merge this if possible.

Copy link
Copy Markdown
Collaborator

@greimel greimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since arrows is used in tests we need to disallow the old Makie versions I suppose?

Comment thread Project.toml Outdated
Comment thread Project.toml Outdated
@greimel
Copy link
Copy Markdown
Collaborator

greimel commented Jun 16, 2025

Let's see if it's as simple as that. The codebase doesn't seem to use arrows, except in a test, so we might be fine.

Unfortunately, tests don't pass, so this can't be merged before the package gets fixed.

@thchr
Copy link
Copy Markdown
Contributor

thchr commented Jun 16, 2025

Seems the test error is because the stored reference images are in RGB and the newly generated images are in RGBA. Comparing the mixed RGB/RGBA is not handled by ReferenceTests.jl. Could potentially just force conversion to RGB in compare.

@hexaeder hexaeder merged commit 045d3d1 into master Jun 17, 2025
5 checks passed
@hexaeder hexaeder deleted the compathelper/new_version/2025-06-12-01-13-35-616-00230053974 branch June 17, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants