cmake: install M2-language-server script#4453
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Oh, I hadn't seen the this script. Aside from cmake conventions, I don't think this script is the right way to go because it doesn't work if M2 isn't on the path or if you have multiple M2's on different paths, e.g. if I'm running M2 from a build directory I might not want the M2-language-server from brew to be used.
I would suggest one two options:
- move this script to the
Macaulay2/bindirectory and adjust it like the M2 script to run the correct M2-binary or just call./M2in the same directory, then move theinstallcall tobin/CMakeFiles.txtand remove theCOPYcall. - better yet, add this invocation as an argument to M2, e.g.
startup.m2should parse--LSPand just run this, with no extra files involved.
|
Ooh, yeah, I like option 1. I'm hesitant about option 2. In particular, I foresee adding command-line options to |
|
You could have a phase 0 check that if |
I just installed M2 on my new MacBook and noticed that the language server script was missing!
The homebrew package uses the cmake build, and (as usual), I don't really understand cmake that well and didn't realize we needed an additional
install(). I figured that just copying it tousr-distlike we do for the autotools build was sufficient. Nope!AI Disclosure
Claude figured out what was missing and added the fix.