Fix -Wparentheses compiler warning - #4424
Open
d-torrance wants to merge 1 commit into
Open
Conversation
d-torrance
added
Engine
jkyang92
reviewed
Jul 9, 2026
Comment on lines
+174
to
+175
| if (!mpfi_is_zero(&x->re) || | ||
| mpfi_is_zero(&x->re) && mpfi_is_zero(&x->im)) { | ||
| (mpfi_is_zero(&x->re) && mpfi_is_zero(&x->im))) { |
Contributor
There was a problem hiding this comment.
This check seems silly. It's !a || (a && b) which is equivalent to !a || b. The change itself is fine.
Member
Author
There was a problem hiding this comment.
Nice catch! I've updated the commit to use this simpler logic (and also the other two complex-number-printing routines in this file)
"nonzero real part or zero" is logically equivalent to "nonzero real part or zero imaginary part" This fixes a previous -Wparentheses compiler warning since the offending parenthese are no longer present. Also use mpfr_zero_p instead of mpfr_cmp_si for simplicity
jkyang92
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following:
AI Disclosure
No AI used