Remove slow EnumerationCurves test#4423
Open
d-torrance wants to merge 1 commit into
Open
Conversation
Runs out of memory on 32-bit systems and takes a long time (~25 s on my system) otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs out of memory on 32-bit systems and takes a long time (~25 s on my system) otherwise.
I asked Claude if we'd be losing anything by removing it, and this was its response (TL;DR: no):
Coverage Analysis: Removing EnumerationCurves TEST 1
Question
If TEST 1 (
rationalCurve(5)) is removed, does any functionality of the packagelose test coverage?
Answer
No. All code paths exercised by TEST 1 are already covered by other tests,
primarily TEST 4.
What TEST 1 Uniquely Exercises
rationalCurve(5)triggers thed == 5branch infixedPoints(
EnumerationCurves.m2:122–179), which is the only place the helper functionsgraph51–graph56are called. Those six helpers are never reached by anydegree ≤ 4 computation.
Why TEST 4 Already Covers That Code Path
multipleCover(d)callsfixedPoints(1, d)internally. TEST 4 assertsmultipleCover(5) == 1/125, which callsfixedPoints(1, 5)and thereforeenters the
d == 5branch. Withr = 1(two torus weights, 0 and 1), theinequality guards (
k != h,h != m,m != n, etc.) are all satisfiable, sograph51–graph56are genuinely called and their results feed into theasserted value.
Coverage Map After Removing TEST 1
rationalCurve(general)d == 5branch infixedPointsmultipleCover(5)graph51–graph56helpersmultipleCover(5)contributionBundle,normalBundlelinesHypersurfacetorusList,fixedPointsdirectly)What Is Lost
The only thing removed is the end-to-end verification of the value
229305888887648 (Katz's count of degree-5 rational curves on the general quintic
threefold). The algorithm producing it remains fully exercised through other
tests; only this specific published constant loses its direct assertion.
Closes: #4413