-
Notifications
You must be signed in to change notification settings - Fork 287
Packages refresh #4408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Packages refresh #4408
Changes from all commits
011e751
751bad5
4a2a279
cf31e75
499cc30
3920804
67cc0b4
71dca34
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -236,23 +236,28 @@ getpkgsrcdir = pkgname -> ( | |
| newPackage = method( | ||
| Dispatch => Thing, | ||
| Options => { | ||
| Authors => {}, | ||
| AuxiliaryFiles => false, | ||
| CacheExampleOutput => null, | ||
| Certification => null, | ||
| Configuration => {}, | ||
| Date => null, | ||
| DebuggingMode => false, | ||
| Headline => null, | ||
| HomePage => null, | ||
| InfoDirSection => "Macaulay2 and its packages", | ||
| Keywords => {"Uncategorized"}, | ||
| OptionalComponentsPresent => null, | ||
| PackageExports => {}, | ||
| PackageImports => {}, | ||
| Reload => false, | ||
| UseCachedExampleOutput => null, | ||
| Version => "0.0" | ||
| Abstract => null, | ||
| ComputingClassificationSystem => {}, | ||
| Areas => {"Uncategorized"}, | ||
| Authors => {}, | ||
| AuxiliaryFiles => false, | ||
| CacheExampleOutput => null, | ||
| Certification => null, | ||
| Configuration => {}, | ||
| LastUpdated => null, | ||
| DebuggingMode => false, | ||
| Headline => null, | ||
| HomePage => null, | ||
| InfoDirSection => "Macaulay2 and its packages", | ||
| Keywords => {}, | ||
| Maintainer => null, | ||
| MathematicsSubjectClassification => {}, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of adding both
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is ok if we're leaving MSC as optional. If we want to make it compulsory (which I think is a good idea - this would be a good thing to be able to search by when we have the package table online) then I wouldn't put them on the same footing. Is there a large group of users who would prefer the ACM classification? (this was mentioned in passing in the summary session, but not discussed). |
||
| OptionalComponentsPresent => null, | ||
| PackageExports => {}, | ||
| PackageImports => {}, | ||
| Reload => false, | ||
| UseCachedExampleOutput => null, | ||
| Version => "0.0" | ||
| }) | ||
| newPackage Sequence := opts -> x -> newPackage splice(nonnull x, opts) -- to allow null entries | ||
| newPackage String := opts -> pkgname -> ( | ||
|
|
@@ -281,13 +286,13 @@ newPackage String := opts -> pkgname -> ( | |
| then error("newPackage: use the Contributors or Acknowledgement keywords to acknowledge contributors of " | pkgname); | ||
| -- optional package values | ||
| scan({ | ||
| (Keywords, List), | ||
| (Date, String), | ||
| (Headline, String), | ||
| (HomePage, String)}, (name, type) -> if opts#name =!= null and not instance(opts#name, type) then | ||
| (Areas, List), | ||
| (LastUpdated, String), | ||
| (Headline, String), | ||
| (HomePage, String)}, (name, type) -> if opts#name =!= null and not instance(opts#name, type) then | ||
| error("newPackage: expected ", toString name, " option of class ", toString type)); | ||
| if opts.Keywords =!= null and any(opts.Keywords, | ||
| keyword -> not instance(keyword, String)) then error "newPackage: expected Keywords to be a list of strings"; | ||
| if opts.Areas =!= null and any(opts.Areas, | ||
| keyword -> not instance(keyword, String)) then error "newPackage: expected Areas to be a list of strings"; | ||
| if opts.Headline =!= null and #opts.Headline > 100 then error "newPackage: expected Headline to be less than 100 characters"; | ||
| -- the options coming from loadPackage are stored here | ||
| loadOptions := if loadPackageOptions#?pkgname then loadPackageOptions#pkgname else loadPackageOptions#"default"; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the key
Datewould cause all existing packages out there to produce an error when loaded. I'm also leaning against this change in general though because I prefer simple key names, but with clear documentation of what they should contain elsewhere.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same forNevermind, you're not removing it so it's not gonna cause errors. I likeKeywords, actually.Areas.