Varieties v0.5: complexes of sheaves#4407
Closed
mahrud wants to merge 29 commits into
Closed
Conversation
This reverts commit 206a197.
d-torrance
reviewed
Jun 5, 2026
| if lo === hi then return complex(sheaf C_lo, Base => lo); | ||
| D := complex applyValues(C.dd.map, sheaf); | ||
| if lo === hi then return complex(sheaf_X C_lo, Base => lo); | ||
| D := complex applyValues(C.dd.map, sheaf_X); |
Member
There was a problem hiding this comment.
In #4395, the proposal is that ComplexMap objects will have a Function key for lazy evaluation instead of just the various integer indices. So applyValues will cause this to fail since we'll be calling sheaf_X on some function.
Member
Author
There was a problem hiding this comment.
I'm aware. I don't think the proposed architecture is compatible with my goals from complexes and resolutions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason #4406 keeps warning that it can't be merged because of conflicts, and I found an online suggestion to split large PR's to have less than 100 commits.