bugfix: standardize loading states and add save spinner to Create pages

[eduardosmaniotto]

Problem 1 — Inconsistent loading states

Merchants, EditConfigGrid, CreateGameServerConfig, and CreateConnectServerConfig used inline spinner-border elements while data loaded, while other pages used the LoadingOverlayService modal overlay. The inline spinners also didn't cover the full page.

Fix: Replaced inline spinners with LoadingOverlayService.ShowLoadingIndicator() modal overlay in all four pages.

Problem 2 — _initState progress messages never visible

The Create pages had a string? _initState that displayed step messages ("Creating configuration...", "Saving...") via InvokeAsync(StateHasChanged). Due to Blazor Server's render batching, intermediate states never reached the client — only the final null rendered, so the div never appeared. The progress messages and their InvokeAsync wrappers were dead code.

Fix: Replaced _initState with bool _isProcessing. Set to true at the top of OnSaveButtonClickAsync, reset in a finally block (so it always clears). Flows into AutoForm's IsProcessing parameter, which disables the Save button and shows a spinner-border-sm. Gives immediate visual feedback without relying on intermediate string updates.

Problem 3 — EF tracking conflict on Merchants discard

OnCancelButtonClickAsync called DiscardChangesAsync then LoadDataAsync, but the old _selectedMerchant was still tracked by EF, causing a tracking conflict.

Fix: Fix: Capture the merchant's Id before discard. After reload, re-select the merchant by matching the ID against the fresh _viewModels.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability and consistency of the admin panel's UI by standardizing how loading states are handled. It addresses issues where inline spinners were used inconsistently, replaces non-functional progress messages with a robust 'is processing' state for form submissions, and resolves a specific entity framework tracking conflict that occurred when discarding changes in the Merchants view.

Highlights

• Standardized Loading States: Replaced inconsistent inline spinners with the centralized LoadingOverlayService across multiple pages to ensure a uniform user experience.
• Improved Save Feedback: Introduced an 'IsProcessing' state in AutoForm to disable the Save button and display a spinner, replacing unreliable progress messages that were failing due to Blazor render batching.
• Resolved EF Tracking Conflict: Fixed a tracking conflict in the Merchants page by clearing view models before reloading data and re-selecting the previously active item by ID.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors loading and processing states across several Blazor pages by introducing a centralized LoadingOverlayService and an IsProcessing parameter on AutoForm, replacing local state spinners. It also localizes the save button text and improves state preservation when discarding changes in the Merchants page. The review feedback highlights critical issues with using ConfigureAwait(false) in Blazor components and event handlers, which can discard the synchronization context and lead to threading or UI update issues. Additionally, it is recommended to avoid setting _viewModels to null before reloading in Merchants.razor.cs to prevent a permanently blank page if the reload fails.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.