fix: harden AudioLoader against SIGSEGV from corrupt/malformed audio frames#1500
Open
xiaden wants to merge 1 commit into
Open
fix: harden AudioLoader against SIGSEGV from corrupt/malformed audio frames#1500xiaden wants to merge 1 commit into
xiaden wants to merge 1 commit into
Conversation
…frames Add defensive guards in both decodePacket() and flushPacket() to prevent segmentation faults when processing corrupted or malformed audio files: - Check for null frame data pointers before memcpy/swr_convert - Validate channel count matches expected layout (prevents swr misuse) - Sanity-check nb_samples to prevent integer overflow in buffer size calc - Skip frames that would overflow FFMPEG_BUFFER_SIZE instead of clamping - Remove redundant std::min() clamping that masked the overflow silently All guards emit E_WARNING with diagnostic details (codec name, sample count, channel count) and skip the offending frame rather than crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Adds defensive guards in both decodePacket() and flushPacket() to prevent segmentation faults when processing corrupted or malformed audio files:
All guards emit E_WARNING with diagnostic details (codec name, sample count, channel count) and skip the offending frame rather than crashing.
Behavior
Notes
This implementation opts to skip invalid frames rather than abort processing. If a different failure strategy is preferred, I’m happy to adapt.
The changes were implemented with AI assistance, and I’m not deeply familiar with all invariants in this codebase, so I’d appreciate careful review, particularly around buffer handling and swr assumptions.