Sort properties by their change interval in the state list#241
Open
BramOtte wants to merge 3 commits into
Open
Sort properties by their change interval in the state list#241BramOtte wants to merge 3 commits into
BramOtte wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state list determines which ids represent which state, not the order of the properties.
This Pull Request sorts the properties to match the state list so any code that depends on the property order to know the ID's is valid.
This currently does not effect the any implemented blocks (hence only the generator is updated) but this does fix the order for for-example the
piston_headblock.Ideally we'd also do some validation in this part of the code so its easier to tell when
complex_transformis necessary ingen_info.yaml.