Skip to content

SEVERE: fix main_media_paths and valid_video_paths out of sync during filtering, causing condition-video misalignment #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lennart Schulze (lenn-arts) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SEVERE: fix main_media_paths and valid_video_paths out of sync during filtering, causing condition-video misalignment #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/process_videos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,17 +213,20 @@ def _filter_valid_videos(self) -> None:
"""Filter out videos with insufficient frames."""
original_length = len(self.video_paths)
valid_video_paths = []
valid_main_media_paths = []
min_frames_required = min(self.resolution_buckets, key=lambda x: x[0])[0]

for video_path in self.video_paths:
for video_path, media_path in zip(self.video_paths, self.main_media_paths):
if video_path.suffix.lower() in [".png", ".jpg", ".jpeg"]:
valid_video_paths.append(video_path)
valid_main_media_paths.append(media_path)
continue

try:
video_reader = decord.VideoReader(uri=video_path.as_posix())
if len(video_reader) >= min_frames_required:
valid_video_paths.append(video_path)
valid_main_media_paths.append(media_path)
else:
logger.warning(
f"Skipping video at {video_path} - has {len(video_reader)} frames, "
Expand All @@ -234,6 +237,7 @@ def _filter_valid_videos(self) -> None:

# Update video paths to only include valid ones
self.video_paths = valid_video_paths
self.main_media_paths = valid_main_media_paths

if len(self.video_paths) < original_length:
logger.warning(
Expand Down