[core] [lua] Make GEO trusts untargetable#10083
Draft
WinterSolstice8 wants to merge 1 commit into
Draft
Conversation
WinterSolstice8
force-pushed
the
geo_trust_untargetable
branch
from
8e93ebd to
2fb4804
Compare
zach2good
reviewed
May 21, 2026
| struct TrustData | ||
| { | ||
| uint32 trustID{}; | ||
| bool isGeoTrust{}; |
Contributor
There was a problem hiding this comment.
Is this not misleading, given that Sylvie exists?
| auto LoadTrust(CCharEntity* PMaster, uint32 TrustID) -> CTrustEntity*; | ||
| void LoadTrustStatsAndSkills(CTrustEntity* PTrust); | ||
|
|
||
| static std::map<SpellID, bool> geoTrustIDs = { |
Contributor
There was a problem hiding this comment.
This can be an unordered set
|
|
||
| bool CTrustEntity::GetUntargetable() const | ||
| { | ||
| if (m_isGeoTrust) |
Contributor
There was a problem hiding this comment.
This override is good, but can we instead use the job GEO without a subjob? Or something along those lines, so we let Sylvie through and block the others?
Contributor
Author
There was a problem hiding this comment.
Changed the naming to be more obvious of the real intent and not purely "job" based though that was largely just a coincidence
WinterSolstice8
force-pushed
the
geo_trust_untargetable
branch
2 times, most recently
from
1862b66 to
94c090c
Compare
WinterSolstice8
force-pushed
the
geo_trust_untargetable
branch
from
94c090c to
ae200a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Make GEO trusts untargetable
Steps to test these changes
Spot check with curaga, ancient circle, mob aoe TP moves, etc