[lua] [sql] Stage 1 Maat Migration to Individualized Luas (War, Rng, Blm)#10049
[lua] [sql] Stage 1 Maat Migration to Individualized Luas (War, Rng, Blm)#10049ThrisStraizo wants to merge 1 commit into
Conversation
ThrisStraizo
force-pushed
the
maatpocalypse
branch
from
c59a66b to
c158f16
Compare
|
|
||
| entity.onMobSpawn = function(mob) | ||
| mob:setUnkillable(true) | ||
| mob:setMod(xi.mod.RATT, 100) |
There was a problem hiding this comment.
It just seems like the damage spread isn't wide enough to convince me its base damage.
I could play around it with some more, idk. It could very well be base damage is decreased.
|
|
||
| entity.onMobSpawn = function(mob) | ||
| mob:setUnkillable(true) | ||
| mob:setBaseSpeed(60) |
There was a problem hiding this comment.
Does BLM maat not have any increased base damage?
| end | ||
|
|
||
| entity.onMobWeaponSkill = function(mob, target, skill, action) | ||
| if skill:getID() == xi.mobSkill.MIGHTY_STRIKES_MAAT then |
There was a problem hiding this comment.
You have the same function written two different ways in different luas.
local skillID = skill:getID()
if skillID == xi.mobSkill.MIGHTY_STRIKES_MAAT then
mob:showText(mob, ID.text.NOW_THAT_IM_WARMED_UP)
return
endThere was a problem hiding this comment.
I made a local for RNG because I call the skill ID for ranged attack further down.
This did make me realize I didn't put the correct 2hrs for the text though.
ThrisStraizo
force-pushed
the
maatpocalypse
branch
from
c158f16 to
ce5e238
Compare
| INSERT INTO `mob_spawn_points` VALUES (17346590,0,'Maat_blm','Maat_blm',10,70,70,83.928,-146.026,295.804,45); -- Maat (BLM arena 3) | ||
| INSERT INTO `mob_spawn_points` VALUES (17346591,0,'Maat_rng','Maat_rng',11,70,70,-396.000,94.000,-64.000,45); -- Maat (RNG arena 1) | ||
| INSERT INTO `mob_spawn_points` VALUES (17346592,0,'Maat_rng','Maat_rng',11,70,70,-156.065,-26.009,115.970,45); -- Maat (RNG arena 2) | ||
| INSERT INTO `mob_spawn_points` VALUES (17346593,0,'Maat_rng','Maat_rng',11,70,70,83.928,-146.026,295.804,45); -- Maat (RNG arena 3) |
There was a problem hiding this comment.
You should only be changing 1 of the rows. The first one.
1 is for the lua lookup. the other is the actual name in the packet.
This PR starts the process to move away from the Maat mixin to individualized luas in addition to making each Maat fight far more accurate than before.
ThrisStraizo
force-pushed
the
maatpocalypse
branch
from
ce5e238 to
99ad1ab
Compare
| INSERT INTO `mob_pools` VALUES (4837,'Maat_rng','Maat',295,0x0000FA0200000000000000000000000000000000,11,0,25,540,100,0,0,0,0,18,0,32,0,155,0,0,0,0,0,335,335,1,17); | ||
| INSERT INTO `mob_pools` VALUES (4835,'Maat_war','Maat_war',295,0x0000FA0200000000000000000000000000000000,1,0,6,480,100,0,0,0,0,18,0,32,0,155,0,0,0,0,0,335,335,1,17); | ||
| INSERT INTO `mob_pools` VALUES (4836,'Maat_blm','Maat_blm',295,0x0000FA0200000000000000000000000000000000,4,0,12,480,100,0,0,0,0,18,0,32,0,155,0,0,2,0,0,335,335,1,17); | ||
| INSERT INTO `mob_pools` VALUES (4837,'Maat_rng','Maat_rng',295,0x0000FA0200000000000000000000000000000000,11,0,25,480,100,0,0,0,0,18,0,32,0,155,0,0,0,0,0,335,335,1,17); |
There was a problem hiding this comment.
Dont change the packet name. Maat
| return | ||
| end | ||
|
|
||
| if mob:isEngaged() then |
There was a problem hiding this comment.
Why wouldnt it be engaged when using an skill?
| return | ||
| end | ||
|
|
||
| if mob:isEngaged() then |
There was a problem hiding this comment.
Same question as before: Why/how wouldnt it be engaged.
|
Holding until Thris is happy with his Maat testing |
3 participants
I affirm:
What does this pull request do?
This PR starts the process to move away from the Maat mixin to individualized luas in addition to making each Maat fight far more accurate than before.
Blm: https://youtu.be/umeqb0oTRy8
War: https://youtu.be/3yzJ-rvXriE
https://youtu.be/C9RN1TcAGLE
Rng: https://youtu.be/RdiTPRu5Ndc
Steps to test these changes
Fight Maat, enjoy more accuracy than ever thought possible.