Migrate the addAddressSupport to return kotlin code properly#2199
Closed
angrezichatterbox wants to merge 13 commits intoLFDT-web3j:web3j-androidfrom
Closed
Conversation
angrezichatterbox
requested review from
NickSneo,
conor10 and
gtebrean
as code owners
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
angrezichatterbox
force-pushed
the
migrate/add-addresses-support-per-file-kotlinpoet
branch
2 times, most recently
from
7bcda9f to
130d1c8
Compare
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
angrezichatterbox
force-pushed
the
migrate/add-addresses-support-per-file-kotlinpoet
branch
from
130d1c8 to
fae51bc
Compare
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
angrezichatterbox
force-pushed
the
migrate/add-addresses-support-per-file-kotlinpoet
branch
from
e0bcc18 to
fd1b276
Compare
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
angrezichatterbox
force-pushed
the
migrate/add-addresses-support-per-file-kotlinpoet
branch
2 times, most recently
from
e13cbd4 to
50a1ee6
Compare
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
angrezichatterbox
force-pushed
the
migrate/add-addresses-support-per-file-kotlinpoet
branch
from
50a1ee6 to
7bb095c
Compare
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
angrezichatterbox
force-pushed
the
migrate/add-addresses-support-per-file-kotlinpoet
branch
2 times, most recently
from
9df5154 to
38ab113
Compare
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
angrezichatterbox
force-pushed
the
migrate/add-addresses-support-per-file-kotlinpoet
branch
from
38ab113 to
917093f
Compare
Signed-off-by: angrezichatterbox <gouthammohanraj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR migrate the addAddressSupport function to properly use KotlinPoet and return Kotlin code properly.
Where should the reviewer start?
codegen/src/main/java/org/web3j/codegen/SolidityFunctionWrapper.java
Why is it needed?
Ensure that the function would return the right output
Checklist