fix: ENS CCIP Read improvements#2164
Merged
gtebrean merged 7 commits intoLFDT-web3j:mainfrom Mar 18, 2025
Merged
Conversation
Member
|
Hey @Syn-McJ , thanks for the useful PR, can you plz sign the DCO to all the commits. |
Signed-off-by: Andrei Ashikhmin <synmcj@gmail.com>
Signed-off-by: Andrei Ashikhmin <synmcj@gmail.com>
Signed-off-by: Andrei Ashikhmin <synmcj@gmail.com>
Signed-off-by: Andrei Ashikhmin <synmcj@gmail.com>
Signed-off-by: Andrei Ashikhmin <synmcj@gmail.com>
Signed-off-by: Andrei Ashikhmin <synmcj@gmail.com>
Signed-off-by: Andrei Ashikhmin <synmcj@gmail.com>
Syn-McJ
force-pushed
the
fix/ens-ccip-read
branch
from
1432376 to
b09b366
Compare
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current implementation of ERC-3668: CCIP Read for ENS name resolution is too strict and doesn't follow the standard exactly.
{sender}parameter is enforced in URL while the standard specifies that it can be sent in POST as part of DTO.resolveWithProofmethod while the standard specifies that thecallbackFunctionfrom OffchainLookup should be used.isEIP3668method might have double quotes that must be stripped.Where should the reviewer start?
The ERC-3668: https://eips.ethereum.org/EIPS/eip-3668#abstract
Why is it needed?
These problems prevent L2 subdomains created with Durin from being resolved, as well as others like
base.ethsubdomains.Checklist