Streamline workspace create & settings form [INS-2621]#9940
Open
godfrzero wants to merge 5 commits into
Open
Conversation
✅ Circular References ReportGenerated at: 2026-05-29T13:25:00.348Z Summary
Click to view all circular references in PR (15)Click to view all circular references in base branch (15)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
godfrzero
commented
May 22, 2026
| <Input | ||
| placeholder={workspaceData.name ? safeToUseInsomniaFileName(workspaceData.name) : 'name'} | ||
| className="w-full min-w-[3ch] outline-hidden [grid-area:input] placeholder:italic focus:outline-hidden" | ||
| className="w-full outline-hidden [grid-area:input] placeholder:italic focus:outline-hidden" |
Contributor
Author
There was a problem hiding this comment.
Enforcing a minimum width on this was leading to a strange gap when typing short filenames one the hardcoded extension was allowed to move around freely:
godfrzero
commented
May 22, 2026
| className="w-full outline-hidden [grid-area:input] placeholder:italic focus:outline-hidden" | ||
| /> | ||
| <span className="-z-10 w-min truncate opacity-0 [grid-area:input]"> | ||
| <span className="pointer-events-none w-min truncate opacity-0 [grid-area:input]"> |
Contributor
Author
There was a problem hiding this comment.
Replaced with pointer-events: none rather than messing with the stacking order since the intent here is to let the user "click through" the element.
The validate callback parameter shadowed the outer `fileName` variable (which holds the original name with extension). The folder-children filter compared against the bare input value instead of the full `fileName`, so the current file was never excluded — causing a false "already exists" error whenever only the workspace name was edited. Renaming the parameter to `inputValue` restores access to the outer `fileName` so the filter correctly excludes the existing file before checking for collisions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The invisible sizer span that drives the CSS grid column width had static content (the initial filename), so the column never resized as the user typed and the .yaml suffix stayed at a fixed position. Switching the TextField to controlled mode (value + onChange) lets the sizer span reflect the live input value, causing the .yaml label to follow the text as characters are added or removed. Also removed the excess pr-7 right-padding since the extension is now positioned by the grid rather than by padding offset. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Apply safeToUseInsomniaFileName to the TextField value prop so the displayed and submitted value is always sanitized, matching the pattern used in new-workspace-modal. Previously the controlled value reflected raw input directly, bypassing character replacement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…workspace settings filename input
pavkout
force-pushed
the
fix/ws-settings-edit
branch
from
32f149e to
682ce9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few usability issues in the "Create a new " and " Settings" modals for Git Sync projects:
Changes were manually tested by comparing v12.6.0-beta.0 and a local dev build. Automated tests were not added for these because unit tests wouldn't effectively test either case and the cost of failure seems too low to add e2e/smoke tests for these. Happy to give the tests a go if that assessment doesn't feel right though.