refactor: remove dead vite config stubs and fix stale comments#10026
Merged
Conversation
- Remove @apidevtools/swagger-parser and mocha from externalDependencies since both are only used in the main process (importers and IPC handler), never in the renderer - Update stale comment claiming nodeIntegration: true is still used - Remove misleading insomnia-testing example from SSR conditions comment - Remove main/types fields from insomnia-testing package.json since they point to a non-existent src/index.ts; all consumers use explicit deep path imports
✅ Circular References ReportGenerated at: 2026-06-04T09:33:51.947Z Summary
Click to view all circular references in PR (8)Click to view all circular references in base branch (8)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
…omments - Remove assert/node:assert aliases — no renderer consumer (jshint, isomorphic-git, events, tough-cookie) requires 'assert' - Condense polyfill comments to show only the evidence (which library needs it) - Update util comment from tough-cookie (moved to main process) to jshint (actual renderer consumer)
ZxBing0066
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@apidevtools/swagger-parserandmochafromexternalDependencies— both are only imported in the main process, never in the renderernodeIntegration: trueis still being usedinsomnia-testingexample from SSR conditions commentmainandtypesfields frominsomnia-testing/package.jsonpointing to non-existentsrc/index.tsWhy
These are leftover from the nodeIntegration=false transition in PR #9996. The config is now dead code that misleads future maintainers.
Testing
npm run type-check -w insomnia✓npm run type-check -w insomnia-testing✓