Skip to content

Make kp::Algorithm and kp::Sequence internals protected for subclassing #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axsaucedo merged 1 commit into from
Apr 7, 2026
Merged

Make kp::Algorithm and kp::Sequence internals protected for subclassing #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/include/kompute/Algorithm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ class Algorithm

void destroy();

private:
protected:
// -------------- NEVER OWNED RESOURCES
std::shared_ptr<vk::Device> mDevice;
std::vector<std::shared_ptr<Memory>> mMemObjects;
Expand All @@ -312,6 +312,7 @@ class Algorithm
std::shared_ptr<vk::Pipeline> mPipeline;
bool mFreePipeline = false;

private:
// -------------- ALWAYS OWNED RESOURCES
std::vector<uint32_t> mSpirv;
void* mSpecializationConstantsData = nullptr;
Expand Down
3 changes: 2 additions & 1 deletion src/include/kompute/Sequence.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ class Sequence : public std::enable_shared_from_this<Sequence>
*/
void destroy();

private:
protected:
// -------------- NEVER OWNED RESOURCES
std::shared_ptr<vk::PhysicalDevice> mPhysicalDevice = nullptr;
std::shared_ptr<vk::Device> mDevice = nullptr;
Expand All @@ -298,6 +298,7 @@ class Sequence : public std::enable_shared_from_this<Sequence>
bool mRecording = false;
bool mIsRunning = false;

private:
// Create functions
void createCommandPool();
void createCommandBuffer();
Expand Down
Loading