Update Metadata#242
Open
vmalieske wants to merge 4 commits into
Open
Conversation
- delete unneccassary roles - implement outlined-input for agent-form - implement functionality for custom-roles - make sure custom-roles will be displayed in list after adding a new one - fix issue when selecting an agent from autocomplete where the value field didn't update accordingly - add a pipe to transform the role type of an agent in a label-form to serve outputs on multiple components
- implement counter for all optional metadata (physObject is just a (1) when there is one) - add a service for any countable objects - move optional metadataType-String into class to make passing the value easier
- change name of editable-field-font-color to display the purpose and make it global - fix issue where existing agents were not found in autoselect by changing the transform params to check for contact-references and name - delete unnecessary rolePipe and get the right display-format from function on entity - delete overpowered counter-system and change it to a regular display of all saved optional data on the specific data-button - update getter on biblioRef as signal to prevent error of change-detection-cycle - fix issue where changes on agent were not detected by updating the specific agent as a new Agent to kick the signal-detection
- cleanup unused methods - set optional chaining when referencing a specific field on entity to prevent legacy-errors - revision roleName-formatting for simplicity and clarity as well as displaying custom names the way users provide them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding Issue #159
Done:
Remains until further notice: