Delayed display of configured slots when working with infinite scrolling#130
Draft
spossner wants to merge 3 commits into
Draft
Delayed display of configured slots when working with infinite scrolling#130spossner wants to merge 3 commits into
spossner wants to merge 3 commits into
Conversation
Author
|
Just realized that the tests are not executed while building - and they break because the display method of GPT is not called anymore if div is not available in dom (as it probably is the case for the jest tests). Need to review that first. -> moved PR back in draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When working with a larger amount of slots which are not in the dom from the very beginning, the current (non dynamic configuration) approach defines and displays all configured slots when setting up gpt. Due to GPTs API reference, slots must be in the dom before calling display. This is violated in the scenario above and ends in console warning messages.
Solution / Proposal
I have introduced a delayed display "list" which stores all IDs of AdvertisingSlots which are defined (in
setupGpt) but not yet found in the dom.When it comes to activation, such slots are displayed before doing the GPT refresh.
Therefore I have refactored the machinsm into a separate
displayAndRefreshSlotsfunction(I have also upgraded the node version to LTS in order to avoid an outdated ssl issue in webpack plus bumped some package versions to avoid vulnerabilities)