Open
Conversation
Owner
|
Sorry I haven't had a chance yet to look at this. I'm still interested though, so I'm re-opening. (Unless you really want it to be closed.) |
Contributor
Author
|
@KevinMusgrave I was not sure about the name I gave to it. I have recently found a work with the exact same name (Dyn-Arcface) (https://www.youtube.com/watch?v=Qa1WWYtYPE8). This algorithm, however, is more of a tech report, as far as I understand. So, I am not sure what to do with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I am working on Dynamic Arcface: https://arxiv.org/pdf/2010.05350.pdf. I implemented a unit test. However, I have some implementation concerns. Particularly, Dynamic Arcface seems to more of a wrapper than a separate DM loss. I would prefer implementing it as a Wrapper class but I would love to know what you think. Thank you!