Skip to content

Better support for custom point types in conjugate_gradient_descent#596

Merged
mateuszbaran merged 1 commit intomasterfrom
mbaran/fix-cg-custom-point
Apr 15, 2026
Merged

Better support for custom point types in conjugate_gradient_descent#596
mateuszbaran merged 1 commit intomasterfrom
mbaran/fix-cg-custom-point

Conversation

@mateuszbaran
Copy link
Copy Markdown
Member

Fixes #533 (comment) .

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e34397f) to head (6898c7e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #596   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           91        91           
  Lines        10025     10025           
=========================================
  Hits         10025     10025           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix.

@mateuszbaran mateuszbaran merged commit ecebd94 into master Apr 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Armijo linesearch does not allocate the right candidate point type

2 participants