Skip to content

Fix RTR with Float32#583

Merged
mateuszbaran merged 1 commit intomasterfrom
mbaran/fix-rtr-float32
Mar 4, 2026
Merged

Fix RTR with Float32#583
mateuszbaran merged 1 commit intomasterfrom
mbaran/fix-rtr-float32

Conversation

@mateuszbaran
Copy link
Copy Markdown
Member

Fixes #582

@mateuszbaran mateuszbaran added the Ready-for-Review A label for pull requests that are feature-ready label Mar 3, 2026
@mateuszbaran mateuszbaran marked this pull request as ready for review March 3, 2026 15:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3f44394) to head (de07beb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #583   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           91        91           
  Lines        10013     10025   +12     
=========================================
+ Hits         10013     10025   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for quickly fixing it.
The convert lines look a bit verbose, but maybe writing that a bit shorter / condensed is also something we can check on a later PR :)

@mateuszbaran
Copy link
Copy Markdown
Member Author

There is a way to remove these convert lines but it would require adding different logic, so I went with the simpler (though a bit more verbose) approach.

@mateuszbaran mateuszbaran merged commit 567b303 into master Mar 4, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready-for-Review A label for pull requests that are feature-ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manopt does not work with Float32 data

2 participants