Fix warning in DebugFeasibility#546
Merged
kellertuer merged 1 commit intoJuliaManifolds:masterfrom Nov 19, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 90 90
Lines 9970 9970
=========================================
Hits 9970 9970 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I think we don't to add a changelog entry here, right? |
Member
|
Yes, well-spotted! My online idea was just typed in a comment and not checked carefully by me before. Logic! Gets you every now and then. |
kellertuer
referenced
this pull request
Nov 26, 2025
…551) Updates the requirements on [ManifoldsBase](https://github.com/JuliaManifolds/ManifoldsBase.jl) and [Manopt](https://github.com/JuliaManifolds/Manopt.jl) to permit the latest version. Updates `ManifoldsBase` to 2.2.1 - [Release notes](https://github.com/JuliaManifolds/ManifoldsBase.jl/releases) - [Changelog](https://github.com/JuliaManifolds/ManifoldsBase.jl/blob/master/NEWS.md) - [Commits](JuliaManifolds/ManifoldsBase.jl@v0.1.0...v2.2.1) Updates `Manopt` to 0.5.28 - [Release notes](https://github.com/JuliaManifolds/Manopt.jl/releases) - [Changelog](https://github.com/JuliaManifolds/Manopt.jl/blob/master/Changelog.md) - [Commits](v0.1.0...v0.5.28) --- updated-dependencies: - dependency-name: ManifoldsBase dependency-version: 2.2.1 dependency-type: direct:production dependency-group: all-julia-packages - dependency-name: Manopt dependency-version: 0.5.28 dependency-type: direct:production dependency-group: all-julia-packages ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we made a small mistake in #545. We want the warning only be shown if
atolis notNaN(the default), right? Currently, it shows the warning if you do not pass anything explicitly toatol. Sorry for not catching that before.