Help with a small objective wrapper to scale objectives#449
Merged
kellertuer merged 4 commits intomasterfrom Apr 10, 2025
Merged
Help with a small objective wrapper to scale objectives#449kellertuer merged 4 commits intomasterfrom
kellertuer merged 4 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 80 81 +1
Lines 8594 8633 +39
=======================================
+ Hits 8584 8623 +39
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
…s/Manopt.jl into kellertuer/scaledObjective
kellertuer
added
the
Ready-for-Review
Member
|
Uh... I wanted to improve it a bit |
Member
Author
|
Sorry :/ then I felt too much in a rush, because I am just finishing for today. Maybe on a new PR? |
Member
|
Yes, I'll make a new PR. Maybe don't tag a new release for a moment, OK? |
Member
Author
|
I even wanted to combine this with the other PR where it will be used anyways |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help in #448
This still needs some tests probably, but the rest should be fine. One could also add proximal maps to the scaling if that is something that is supported in JuMP.