[WIP] HermitianPositiveDefinite#813
Draft
kellertuer wants to merge 13 commits intomasterfrom
Draft
Conversation
Member
|
Yes, I think the SPD should just be an alias for real-coefficient HPD. |
Member
Author
|
Well, if we manage to finish that, for now I struggle a bit to find time to continue, but I will try to continue this step by step though maybe I am a bit slow since for anything beyond checks of points/vectors I first have to read up on the formulae as well. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
===========================================
- Coverage 100.00% 99.56% -0.44%
===========================================
Files 98 99 +1
Lines 9745 9797 +52
===========================================
+ Hits 9745 9754 +9
- Misses 0 43 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
No problem, this change is largely independent of the core work of implementing complex HPD. |
# Conflicts: # NEWS.md # test/runtests.jl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started the HPDs as proposed in #811, but here at home I noticed that programming on a German layout is not something I am used to.
The idea is to
📋
constof the HPD-HermitianPositiveDefinite{ℝ} caseCheck a bit for literature and document carefully. Feel free to check functions as well otherwise I will slowly work through the affine invariant metric.