Skip to content

Fix missing p_start update in hinge midpoint loop #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asinghvi17 merged 3 commits into from
Apr 19, 2026
Merged

Fix missing p_start update in hinge midpoint loop #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fcadc8
Fix missing `p_start` update in `_line_filled_curve_interactions` hin…
asinghvi17 Apr 4, 2026
92a8d43
Add regression test for `within` with collinear notch polygon (#396)
asinghvi17 Apr 4, 2026
0f3f28b
Bump version from 0.1.38 to 0.1.39
asinghvi17 Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "GeometryOps"
uuid = "3251bfac-6a57-4b6d-aa61-ac1fef2975ab"
authors = ["Anshul Singhvi <anshulsinghvi@gmail.com>", "Rafael Schouten <rafaelschouten@gmail.com>", "Skylar Gering <skygering@gmail.com>", "and contributors"]
version = "0.1.38"
version = "0.1.39"

[deps]
AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
Expand Down
1 change: 1 addition & 0 deletions src/methods/geom_relations/geom_geom_processors.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,7 @@ function _line_filled_curve_interactions(
elseif mid_val == point_out
out_curve = true
end
p_start = p_end
end
# already checked segment against whole filled curve
l_start = l_end
Expand Down
5 changes: 5 additions & 0 deletions test/methods/geom_relations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ p10 = LG.Polygon([
[[0.15, 0.55], [0.15, 0.95], [0.55, 0.95], [0.55, 0.55], [0.15, 0.55]]
])
p11 = LG.Polygon(r3)
# Polygon with interior notch sharing collinear edges with a rectangle (issue #396)
p12 = LG.Polygon([[[0.0, 0.0], [0.0, 4.0], [8.0, 4.0], [8.0, 0.0], [0.0, 0.0]]])
p13 = LG.Polygon([[[0.0, 0.0], [0.0, 2.0], [7.0, 1.0], [7.0, 3.0], [0.0, 3.0], [0.0, 4.0], [8.0, 4.0], [8.0, 0.0], [0.0, 0.0]]])

mpt1 = LG.MultiPoint([pt1, pt2])
mpt2 = LG.MultiPoint([pt2, pt3])
Expand Down Expand Up @@ -157,6 +160,8 @@ test_pairs = [
(p6, p1, "p6", "p1", "Polygon inside of other polygon's hole"),
(p7, p1, "p7", "p1", "Polygons overlap"),
(p10, p1, "p10", "p1", "Polygon's with nested holes"),
(p12, p13, "p12", "p13", "Rectangle with polygon with collinear notch (#396)"),
(p13, p12, "p13", "p12", "Polygon with collinear notch inside rectangle (#396)"),
# Multigeometries
(mpt1, mpt1, "mpt1", "mpt1", "Same set of points for multipoints"),
(mpt1, mpt2, "mpt1", "mpt2", "Some point matches, others are different"),
Expand Down
Loading