Conversation
`compute_divisibility` used `<=` instead of `<` in its loop bound, allowing the result to overshoot `max_divisor`. With the default max_divisor=16, any shape divisible by 32 (common in GPU workloads) would produce a `DivBy(32)` assume in the Tile IR bytecode instead of the intended `DivBy(16)`, mismatching cuTile Python's behavior and causing unnecessary kernel respecialization via ArraySpec type params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute_divisibilityused<=instead of<in its loop bound, allowing the result to overshootmax_divisor. With the default max_divisor=16, any shape divisible by 32 (common in GPU workloads) would produce aDivBy(32)assume in the Tile IR bytecode instead of the intendedDivBy(16), mismatching cuTile Python's behavior and causing unnecessary kernel respecialization via ArraySpec type params.