Use an extra bit of entropy in the Float64 uniform 0-1 distribution.#712
Closed
nhz2 wants to merge 1 commit intoJuliaGPU:masterfrom
Closed
Use an extra bit of entropy in the Float64 uniform 0-1 distribution.#712nhz2 wants to merge 1 commit intoJuliaGPU:masterfrom
nhz2 wants to merge 1 commit intoJuliaGPU:masterfrom
Conversation
Author
|
I think the @inline function u01(::Type{Float64}, u::UInt64)::Float64
fma(Float64(u), Float64(2)^Int32(-64), Float64(2)^Int32(-65))
endSeems to be fine performance wise. Ref: https://github.com/medyan-dev/PhiloxRNG.jl/tree/v1.1.1#gpu--nvidia-geforce-rtx-3080-nsvalue-n--100000000 |
Member
This was fixed in JuliaGPU/CUDA.jl#3098, which I encountered as part of porting your RNG. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking over #707 I think the following is a slight improvement for
Float64u01.This PR subtracts
prevfloat(1.0)to avoid returning zero fromu01while still using 52 bits.cc @maleadt