Use Republic.jl to forward subpackage APIs#3103
Draft
AntonOresten wants to merge 2 commits intoJuliaGPU:masterfrom
Draft
Use Republic.jl to forward subpackage APIs#3103AntonOresten wants to merge 2 commits intoJuliaGPU:masterfrom
AntonOresten wants to merge 2 commits intoJuliaGPU:masterfrom
Conversation
Member
|
Interesting! I'd be fine with depending on Republic.jl for this. Any reason you went with a new package, and not an extension to Reexport.jl? Especially seeing the |
Contributor
Author
|
Reexport.jl has a very clear scope, and the There could definitely be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently created Republic.jl to replace and extend Reexport.jl. After jumping the gun on v1 (which had questionable inheritance semantics) I'm now much more confident in v2, taking inspiration from the pre-1.11
@publicmachinery from #3058.The previous code has special handling for GPUToolbox.jl's enums, so this PR relies on GPUToolbox switching to Republic.jl as well for pre-1.11 enum support.
This would be my first real stress-test of Republic, but I don't see any potential problems yet.