Merged
Conversation
kshyatt
added
bugfix
Member
Author
|
OK, the full testsuite passed for me on |
Member
Author
|
OK, 1.11.1 looks good too. I think this is good to go. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2703 +/- ##
==========================================
+ Coverage 83.51% 83.66% +0.14%
==========================================
Files 153 153
Lines 13592 13588 -4
==========================================
+ Hits 11351 11368 +17
+ Misses 2241 2220 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Can we make a new patch release with this fix? |
Member
Author
|
cc @maleadt ^ |
Member
Author
Contributor
|
Thank you! |
Member
Author
|
New version tagged! Did that fix everything? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #2690. I tested locally on 1.11.1 and 1.11.2 and was able to precompile on both. Currently running tests to make sure nothing broke.
cc @scheidan @waywardpidgeon @oschulz and @bgctw