Skip to content

Loosen VERSION check for sketchy test#2688

Merged
kshyatt merged 1 commit intomasterfrom
ksh/alloc_broken
Mar 12, 2025
Merged

Loosen VERSION check for sketchy test#2688
kshyatt merged 1 commit intomasterfrom
ksh/alloc_broken

Conversation

@kshyatt
Copy link
Copy Markdown
Member

@kshyatt kshyatt commented Mar 11, 2025

No description provided.

@kshyatt kshyatt added the tests Adds or changes tests. label Mar 11, 2025
@kshyatt kshyatt requested a review from maleadt March 11, 2025 17:40
@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented Mar 11, 2025

We're getting a cool new failure on nightly now!

@kshyatt kshyatt enabled auto-merge (squash) March 11, 2025 20:22
@kshyatt kshyatt disabled auto-merge March 11, 2025 20:25
@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented Mar 11, 2025

Benchmarks failure again!!!

@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented Mar 11, 2025

OK, I tried making the buildkite benchmarks soft fail for now because they seem to be having this segfault 50% of the time for no obvious reason. I can remove that if you want.

@kshyatt kshyatt requested review from maleadt March 11, 2025 20:29
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA.jl Benchmarks

Details
Benchmark suite Current: 51712d5 Previous: c75b56f Ratio
latency/precompile 46313827323.5 ns 46181620127.5 ns 1.00
latency/ttfp 7037908230 ns 7068629094 ns 1.00
latency/import 3716077422 ns 3724762175 ns 1.00
integration/volumerhs 9610295.5 ns 9624216.5 ns 1.00
integration/byval/slices=1 146899 ns 146894 ns 1.00
integration/byval/slices=3 425263 ns 425137.5 ns 1.00
integration/byval/reference 145124 ns 144952 ns 1.00
integration/byval/slices=2 286195 ns 285936 ns 1.00
integration/cudadevrt 103493 ns 103412 ns 1.00
kernel/indexing 14196.5 ns 14099 ns 1.01
kernel/indexing_checked 14613 ns 14674 ns 1.00
kernel/occupancy 670.4746835443038 ns 701.1379310344828 ns 0.96
kernel/launch 2106.4 ns 2179.6666666666665 ns 0.97
kernel/rand 14677 ns 14749 ns 1.00
array/reverse/1d 19916 ns 19776 ns 1.01
array/reverse/2d 25288 ns 24908 ns 1.02
array/reverse/1d_inplace 10303.666666666666 ns 10219 ns 1.01
array/reverse/2d_inplace 11187 ns 11910 ns 0.94
array/copy 20964 ns 21311 ns 0.98
array/iteration/findall/int 159143.5 ns 158209 ns 1.01
array/iteration/findall/bool 139817 ns 139123 ns 1.00
array/iteration/findfirst/int 154914 ns 153168 ns 1.01
array/iteration/findfirst/bool 155666 ns 154631 ns 1.01
array/iteration/scalar 72439 ns 71886 ns 1.01
array/iteration/logical 217182.5 ns 213254 ns 1.02
array/iteration/findmin/1d 42081 ns 40786 ns 1.03
array/iteration/findmin/2d 94580 ns 93428 ns 1.01
array/reductions/reduce/1d 41568.5 ns 35669 ns 1.17
array/reductions/reduce/2d 52059.5 ns 40477 ns 1.29
array/reductions/mapreduce/1d 38997.5 ns 33443 ns 1.17
array/reductions/mapreduce/2d 46567 ns 40694.5 ns 1.14
array/broadcast 20826 ns 20825 ns 1.00
array/copyto!/gpu_to_gpu 11944 ns 13806 ns 0.87
array/copyto!/cpu_to_gpu 209875 ns 208873 ns 1.00
array/copyto!/gpu_to_cpu 244753 ns 242948 ns 1.01
array/accumulate/1d 109555.5 ns 108924 ns 1.01
array/accumulate/2d 80718 ns 80034 ns 1.01
array/construct 1296.6 ns 1297.3 ns 1.00
array/random/randn/Float32 45226.5 ns 43906.5 ns 1.03
array/random/randn!/Float32 26880.5 ns 26669 ns 1.01
array/random/rand!/Int64 27190 ns 27027 ns 1.01
array/random/rand!/Float32 8734.333333333334 ns 8863 ns 0.99
array/random/rand/Int64 30119 ns 30048.5 ns 1.00
array/random/rand/Float32 13333 ns 13342 ns 1.00
array/permutedims/4d 61679 ns 60675.5 ns 1.02
array/permutedims/2d 55656.5 ns 55115.5 ns 1.01
array/permutedims/3d 56907 ns 55700 ns 1.02
array/sorting/1d 2766854 ns 2777689 ns 1.00
array/sorting/by 3356251 ns 3368739 ns 1.00
array/sorting/2d 1082520.5 ns 1084912 ns 1.00
cuda/synchronization/stream/auto 1036.9 ns 1013.5384615384615 ns 1.02
cuda/synchronization/stream/nonblocking 6570.2 ns 6485.2 ns 1.01
cuda/synchronization/stream/blocking 813.8505154639174 ns 826 ns 0.99
cuda/synchronization/context/auto 1160.6 ns 1197.3 ns 0.97
cuda/synchronization/context/nonblocking 6804 ns 6768.6 ns 1.01
cuda/synchronization/context/blocking 935.3913043478261 ns 946.4193548387096 ns 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@kshyatt
Copy link
Copy Markdown
Member Author

kshyatt commented Mar 12, 2025

Oh my god now it's Enzyme rip

@kshyatt kshyatt enabled auto-merge (squash) March 12, 2025 02:53
@kshyatt kshyatt merged commit dd7ad79 into master Mar 12, 2025
2 of 3 checks passed
@kshyatt kshyatt deleted the ksh/alloc_broken branch March 12, 2025 05:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.86%. Comparing base (c75b56f) to head (51712d5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2688       +/-   ##
===========================================
+ Coverage   68.59%   82.86%   +14.26%     
===========================================
  Files         153      153               
  Lines       13520    13607       +87     
===========================================
+ Hits         9274    11275     +2001     
+ Misses       4246     2332     -1914     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Adds or changes tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants