Skip to content

ci: no fail-fast for unittests#1820

Merged
kristapsk merged 1 commit intoJoinMarket-Org:masterfrom
3nprob:ci-no-fail-fast
Nov 29, 2025
Merged

ci: no fail-fast for unittests#1820
kristapsk merged 1 commit intoJoinMarket-Org:masterfrom
3nprob:ci-no-fail-fast

Conversation

@3nprob
Copy link
Copy Markdown

@3nprob 3nprob commented Nov 1, 2025

Let all unittest jobs finish to completion even if one in the matrix fails.

This should make it easier and quicker to distinguish between:

  • Legitimate new regressions affecting all runtimes
  • Flaky tests
  • Differences between runtimes
  • Whether errors are consistent or intermittent

without manually restarting or retrying.

https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstrategyfail-fast

Also ensures results for master have complete coverage (for example one was skipped for 5246c1c: https://github.com/JoinMarket-Org/joinmarket-clientserver/actions/runs/18861473464/job/53820509485 )

@3nprob 3nprob marked this pull request as ready for review November 1, 2025 01:27
Copy link
Copy Markdown
Member

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr utACK 9eaca78

@kristapsk kristapsk merged commit ce32baf into JoinMarket-Org:master Nov 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants