fix up the problem in model_profiling when fed 'Modulelist'#59
Open
13015517713 wants to merge 1 commit intoJiahuiYu:masterfrom
Open
fix up the problem in model_profiling when fed 'Modulelist'#5913015517713 wants to merge 1 commit intoJiahuiYu:masterfrom
13015517713 wants to merge 1 commit intoJiahuiYu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Introduction:
Module.register_forward_hook function adds hooks to each module (with forward function) without ModuleList. So ModuleList module does not record the profile including macs and params. When traversing deep-first module.children fcuntion does not calculate the profile when this module is a instance of ModuleList.
Problem Reproduction:
You can try to modify "self.blocks" in model.py to the instance of ModuleList.
Solution:
I handle ModuleList specially, recording to each non-ModuleList submodule.