test(quota-monitor): add timezone boundary coverage#5747
Conversation
|
@pari-28 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
I reviewed the PR title/description, linked issue #2930, checks, and the diff before labeling.
Labels applied:
level:beginner: the change is a 69-line timezone-boundary test file inservices/github/quota-monitor.timezone-boundaries.test.ts, and it stays focused on reset-time handling.quality:clean: the test cases are short, explicit, and close to the quota monitor API being exercised.type:testing: the PR is dedicated test coverage for quota-monitor timezone boundaries.type:logic: the assertions are about timestamp normalization and date-boundary behavior, which is the core logic under test.
I’m leaving this as a neutral comment rather than approving because the repo checks are green but the PR is still carrying a failing Vercel status context. That looks like a deployment integration/auth issue rather than a code failure.
To unblock it, the Vercel GitHub integration for the repo/team needs to be re-authorized or the status needs to be marked non-blocking by maintainers. Once the Vercel context is green, this can be reviewed normally.
Aamod007
left a comment
There was a problem hiding this comment.
Good narrow test coverage for the quota monitor. services/github/quota-monitor.timezone-boundaries.test.ts exercises the reset-time parsing across UTC, leap-year, and DST-style boundaries, which is exactly where this sort of state can get slippery.
|
🎉 Congratulations @pari-28! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Fixes #2930
Added
services/github/quota-monitor.timezone-boundaries.test.tsto provide isolated test coverage for timezone normalization and calendar boundary scenarios in the quota monitor.Added Test Coverage
Validation
npm run typecheckpasses successfullyPillar
Visual Preview
N/A (test-only change)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.