test(HistoricalTrendView): add empty-fallback edge case tests#5740
Open
Mahi11Patel wants to merge 2 commits into
Open
test(HistoricalTrendView): add empty-fallback edge case tests#5740Mahi11Patel wants to merge 2 commits into
Mahi11Patel wants to merge 2 commits into
Conversation
Author
|
Hi @JhaSourav07 , |
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
approved these changes
Jun 15, 2026
Aamod007
left a comment
Collaborator
There was a problem hiding this comment.
Good fallback coverage here. The updated components/dashboard/HistoricalTrendView.empty-fallback.test.tsx and the new components/AnimatedCursor.empty-fallback.test.tsx cover the empty activity state, period/navigation controls, and cursor fallback behavior without changing production code, so this is a clean test-only addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4255
This PR adds the missing test file
components/dashboard/HistoricalTrendView.empty-fallback.test.tsxas required by the issue.The test file covers 5 edge cases for the
HistoricalTrendViewcomponent when activity data is empty or missing:All 5 tests pass with
vitest run.Pillar
Visual Preview
N/A — test file only, no SVG changes
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.