Skip to content

test: add empty fallback coverage for CustomizeCTA#5737

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
deepsikha-dash:test-customizecta-empty-fallback
Jun 15, 2026
Merged

test: add empty fallback coverage for CustomizeCTA#5737
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
deepsikha-dash:test-customizecta-empty-fallback

Conversation

@deepsikha-dash

Copy link
Copy Markdown
Contributor

Description

Added empty fallback test coverage for CustomizeCTA to verify component stability when translation values are empty, undefined, or missing. The new tests ensure the CTA structure and navigation link remain available without runtime failures.

Fixes #4211

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@deepsikha-dash is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3433.84 KB 3433.84 KB 0 B
Total CSS 258.05 KB 258.05 KB 0 B

@Aamod007 Aamod007 added level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests mentor:Aamod007 labels Jun 15, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked by the Vercel deployment authorization check rather than a code problem. Please authorize the linked deploy, rerun checks, and then we can take another look at the empty-fallback coverage in app/components/CustomizeCTA.empty-fallback.test.tsx.

@Aamod007 Aamod007 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 15, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fallback coverage for the CTA. app/components/CustomizeCTA.empty-fallback.test.tsx checks empty, undefined, and null-like translations while keeping the customize link and structure intact, which is exactly the kind of regression coverage we want.

@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 15, 2026
@JhaSourav07 JhaSourav07 merged commit c9897a7 into JhaSourav07:main Jun 15, 2026
10 of 11 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @deepsikha-dash! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(CustomizeCTA-empty-fallback): verify Edge Cases & Empty/Missing Inputs Verification (Variation 1)

3 participants