-
-
Notifications
You must be signed in to change notification settings - Fork 29
Refactor cleanup #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor cleanup #45
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,4 +64,4 @@ release.sh | |
| html | ||
| .DS_Store | ||
| .mkdoxy | ||
| site/ | ||
| site/ | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,4 +19,4 @@ repos: | |
| - id: check-merge-conflict | ||
|
|
||
| default_language_version: | ||
| python: python3.8 | ||
| python: python3.12 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| refactor: | ||
| skip: | ||
| - use-named-expression # Python 3.8+ | ||
| - use-named-expression # Python 3.8+ |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -203,7 +203,7 @@ See the [examples/](https://github.com/JakubAndrysek/PySpaceMouse/tree/master/ex | |||||
| ### Linux permissions | ||||||
|
|
||||||
| ```bash | ||||||
| sudo echo 'KERNEL=="hidraw*", SUBSYSTEM=="hidraw", MODE="0664", GROUP="plugdev"' > /etc/udev/rules.d/99-hidraw-permissions.rules | ||||||
| echo 'KERNEL=="hidraw*", SUBSYSTEM=="hidraw", MODE="0664", GROUP="plugdev"' | sudo tee /etc/udev/rules.d/99-hidraw-permissions.rules | ||||||
| sudo usermod -aG plugdev $USER | ||||||
| newgrp plugdev | ||||||
| ``` | ||||||
|
|
@@ -218,8 +218,22 @@ export DYLD_LIBRARY_PATH=/opt/homebrew/Cellar/hidapi/<VERSION>/lib:$DYLD_LIBRARY | |||||
|
|
||||||
| See [troubleshooting.md](./troubleshooting.md) for help with common issues. | ||||||
|
|
||||||
| ## Used In | ||||||
| ## Developing / Contributing | ||||||
|
|
||||||
| This project includes a `Makefile` with commands for creating a virtual environment (using hatch), and publishing to pypi. | ||||||
|
|
||||||
| You will need `hatch` and `pre-commit` for this. | ||||||
| You can get these by using | ||||||
|
|
||||||
| ``` | ||||||
| pipx install hatch==1.15.1 pre-commit | ||||||
| ``` | ||||||
|
|
||||||
| If you're not familiar with pipx, it lets you install python tools into isolated environments in `~/.local`. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nitpick (typo): Capitalize “Python” when referring to the language. Change
Suggested change
|
||||||
|
|
||||||
| For building the documentation locally, you will also need `doxygen` installed and on the path. | ||||||
|
|
||||||
| ## Used In | ||||||
|
|
||||||
| - [TeleMoMa](https://github.com/UT-Austin-RobIn/telemoma) - A Modular and Versatile Teleoperation System for Mobile Manipulation | ||||||
| - [SERL](https://github.com/rail-berkeley/serl) - SERL: A Software Suite for Sample-Efficient Robotic Reinforcement Learning | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| spacemouse.kubaandrysek.cz | ||
| spacemouse.kubaandrysek.cz |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -203,7 +203,7 @@ See the [examples/](https://github.com/JakubAndrysek/PySpaceMouse/tree/master/ex | |||||
| ### Linux permissions | ||||||
|
|
||||||
| ```bash | ||||||
| sudo echo 'KERNEL=="hidraw*", SUBSYSTEM=="hidraw", MODE="0664", GROUP="plugdev"' > /etc/udev/rules.d/99-hidraw-permissions.rules | ||||||
| echo 'KERNEL=="hidraw*", SUBSYSTEM=="hidraw", MODE="0664", GROUP="plugdev"' | sudo tee /etc/udev/rules.d/99-hidraw-permissions.rules | ||||||
| sudo usermod -aG plugdev $USER | ||||||
| newgrp plugdev | ||||||
| ``` | ||||||
|
|
@@ -218,8 +218,20 @@ export DYLD_LIBRARY_PATH=/opt/homebrew/Cellar/hidapi/<VERSION>/lib:$DYLD_LIBRARY | |||||
|
|
||||||
| See [troubleshooting.md](./troubleshooting.md) for help with common issues. | ||||||
|
|
||||||
| ## Used In | ||||||
| ## Developing / Contributing | ||||||
|
|
||||||
| This project includes a `Makefile` with commands for creating a virtual environment (using hatch), and publishing to pypi. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (typo): Use the correct capitalization for PyPI. In this sentence, update
Suggested change
|
||||||
|
|
||||||
| You will need `hatch` and `pre-commit` for this. | ||||||
| You can get these by using | ||||||
|
|
||||||
| ``` | ||||||
| pipx install hatch==1.15.1 pre-commit | ||||||
| ``` | ||||||
|
|
||||||
| If you're not familiar with pipx, it lets you install python tools into isolated environments in `~/.local`. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nitpick (typo): Capitalize “Python” when referring to the language.
Suggested change
|
||||||
|
|
||||||
| ## Used In | ||||||
|
|
||||||
| - [TeleMoMa](https://github.com/UT-Austin-RobIn/telemoma) - A Modular and Versatile Teleoperation System for Mobile Manipulation | ||||||
| - [SERL](https://github.com/rail-berkeley/serl) - SERL: A Software Suite for Sample-Efficient Robotic Reinforcement Learning | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Use the correct capitalization for PyPI.
Change
pypitoPyPIin this sentence.