Corrected a bug (segfault) occuring when no positive idepth is available#81
Open
MorganChabaud wants to merge 1 commit into
Open
Corrected a bug (segfault) occuring when no positive idepth is available#81MorganChabaud wants to merge 1 commit into
MorganChabaud wants to merge 1 commit into
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A segmentation fault can occur when no positive idepth is available on a level. This patch corrects it.
It also adds a condition check in order to avoid going in two debug functions (which are useless when "sampleoutput=1" is not set (launch parameter) nor debugSaveImages is true).
And these functions (mostly debugPlotIDepthMap) actually take a bit of processing time (around 25ms on Raspberry Pi 3) for 512x512 images even if the debug options are not set ("debugSaveImages=0" (default) and debugSaveImages=false (default)).