Corrected Keyframe parameters#138
Open
muskie82 wants to merge 1 commit into
Open
Conversation
Collaborator
|
You are probably right that this should depend on the actual resolution. However without tests on multiple different resolutions, its hard to tell if the proposed change leads to improved performance. It probably also depends a lot on the actual movement what would be best here... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters for keyframe selection should depend on the input image resolution, but currently fixed values (640*480) are used for these parameters.
So I used wG[0] and hG[0] for raw input image resolution.
Thank you