Cmake, travis, and others#109
Open
NikolausDemmel wants to merge 28 commits into
Open
Conversation
It seems like you might need a `const` for the first argument of `std::pair` in `aligned_allocator`, see JakobEngel#111. Added some `override` statements to Output3DWrapper's derived classes.
…llation of the required headers files.
- the sse related flags and defines seem to be unused
- dynamic library is now default - libzip-dev should be fine from apt on 16.04 - hint on camera calibration and 0.5 offset for OpenCV and Kalibr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a mix of changes, mostly concerning the build system.
Travis: Added automatic compile checks on Linux and OSX using Travis.
CMake changes:
cmake -DDSO_BUILD_STATIC_LIBRARY=On.Releaseis set.catkin_toolsas a cmake package. The accordingpackage.xmlis included. (Future work: Detect presence of ROS and optionally build as catkin-package).Readme was updated with respect to install instructions.
Warnings are fixed, both in DSO code and in Sophus code (we should really update to the latest upstream version of Sophus, to get all bug fixes).
The only functional code change is the fix proposed in #89, which also shows up as a build warning (with clang).
Closes #101.