Add SCRAPER_BROWSER_TYPE / SCRAPER_EXECUTABLE_PATH env vars#1159
Draft
feder-cr wants to merge 1 commit into
Draft
Add SCRAPER_BROWSER_TYPE / SCRAPER_EXECUTABLE_PATH env vars#1159feder-cr wants to merge 1 commit into
feder-cr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scraper's browser launch was hardcoded to chromium with no way to point it at a different engine or binary. Adds SCRAPER_BROWSER_TYPE (default 'chromium', unchanged behavior) and SCRAPER_EXECUTABLE_PATH, and guards the Chromium-specific channel/args behind the default case. Motivated by invisible_playwright, a Playwright wrapper around a Firefox build patched at the source level for a realistic fingerprint, useful for sites that fingerprint the scraper. Opened as draft, happy to adjust naming or scope.
Summary by cubic
Makes the scraper’s browser configurable so you can choose the
playwrightengine and optionally point to a custom binary. Defaults stay the same (Chromium with current flags), so no changes needed for existing setups.chromium,firefox, orwebkit(default:chromium).chromium.Written for commit 14a79d7. Summary will update on new commits.