Removes commented code

Author: spirali

crates/hyperqueue/src/server/client/submit.rs

@@ -38,7 +38,6 @@ fn create_task_submit(
             task_desc,
             resource_rq,
         } => {
-            //let rqv = grm.convert_client_resource_rq(resource_rq);
             let resource_rq_id = server_ref.get_or_create_resource_rq_id(resource_rq);
             build_tasks_array(
                 job_id,

crates/hyperqueue/src/transfer/messages.rs

@@ -30,7 +30,6 @@ pub enum FromClientMessage {
     /// It is basically as sending Submit and StreamEvents, but it is done atomically,
     /// so no message is lost.
     Submit(SubmitRequest, Option<StreamEvents>),
-    //GetResourceRqId(Vec<ResourceRequestVariants>),
     Cancel(CancelRequest),
     ForgetJob(ForgetJobRequest),
     JobDetail(JobDetailRequest),

crates/hyperqueue/src/transfer/mod.rs

@@ -1,5 +1,4 @@
 pub mod auth;
 pub mod connection;
 pub mod messages;
-pub mod protocol;
 pub mod stream;

crates/hyperqueue/src/transfer/protocol.rs

@@ -129,7 +129,6 @@ static_assert_size!(Task, 96);
 
 impl fmt::Debug for Task {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        //let task_ids : Vec<_> = self.tasks.iter().map(|r| r.get().id.to_string()).collect();
         f.debug_struct("Task")
             .field("id", &self.id)
             .field("state", &self.state)

crates/tako/src/internal/server/task.rs

@@ -144,8 +144,6 @@ fn test_worker_add() {
 #[test]
 fn test_scheduler_priority() {
     let mut rt = TestEnv::new();
-    //new_workers(&mut core, &mut comm, vec![1]);
-
     let t = TaskBuilder::new();
 
     let t1 = rt.new_task(&t);

crates/tako/src/internal/tests/test_reactor.rs

@@ -116,18 +116,6 @@ fn try_start_task(
         return Some(allocation);
     }
 
-    // let Some(allocation) = state.allocator.try_allocate(&rq) else {
-    //     // Soft reject, we remember rejection as we unblock in the future
-    //     state
-    //         .blocked_requests
-    //         .insert((task.resource_rq_id, resource_rq_variant));
-    //     task_updates.push(WorkerTaskUpdate::RejectRequest {
-    //         task_id: task.id,
-    //         resource_rq_variant,
-    //     });
-    //     return Some(allocation);
-    // };
-
     match launch_task(state, &task, rv_id, &allocation) {
         Ok((task_comm, task_context)) => {
             let msg = TaskRunningMsg {
@@ -198,7 +186,6 @@ fn launch_task(
             log::debug!("Task initialization failed id={task_id}, error={error:?}");
             state.lc_state.borrow_mut().unregister_token(&token);
             Err(error)
-            //state.finish_task_failed(task_id, TaskFailInfo::from_string(error.to_string()));
         }
     }
 }

crates/tako/src/internal/worker/reactor.rs

@@ -10,7 +10,6 @@ use crate::resources::{
     ResourceIndex, ResourceUnits,
 };
 
-
 impl ResourceAllocator {
     pub fn get_sockets(&self, allocation: &Allocation, idx: u32) -> Vec<usize> {
         let idx = ResourceId::new(idx);
@@ -1071,21 +1070,3 @@ fn test_tight_scattering() {
     assert_eq!(r1[4].group_idx, r1[5].group_idx);
     assert_ne!(r1[0].group_idx, r1[4].group_idx);
 }
-
-// #[test]
-// fn test_coupling_tight() {
-//     for coupled in [true, false] {
-//         let descriptor = descriptor_cpus_gpus(3, 4, 2, coupled);
-//         let mut allocator = test_allocator(&descriptor);
-//
-//         allocator.force_claim_from_groups(0.into(), &[0], 4.into());
-//         allocator.force_claim_from_groups(1.into(), &[1, 2], 4.into());
-//
-//         let rq = ResBuilder::default()
-//             .add_force_compact(0, ResourceAmount::new_units(1))
-//             .add_force_compact(1, ResourceAmount::new_units(1))
-//             .finish_v();
-//         let al = allocator.try_allocate(&rq);
-//         assert_eq!(al.is_none(), coupled);
-//     }
-// }

crates/tako/src/internal/worker/resources/test_allocator.rs

@@ -179,11 +179,9 @@ pub async fn run_worker(
         Some(d) => Either::Right(tokio::time::sleep(d)),
     };
     let future = async move {
-        //let try_start_tasks = task_starter_process(state_ref.clone(), start_task_notify);
         let send_loop = forward_queue_to_sealed_sink(queue_receiver, sender, sealer);
         tokio::pin! {
             let send_loop = send_loop;
-            //let try_start_tasks = try_start_tasks;
         }
 
         let result: crate::Result<Option<FromWorkerMessage>> = tokio::select! {
@@ -203,7 +201,6 @@ pub async fn run_worker(
                 log::info!("Worker received an external stop notification");
                 Ok(Some(FromWorkerMessage::Stop(WorkerStopReason::Interrupted)))
             }
-            //_ = &mut try_start_tasks => { unreachable!() }
             _ = heartbeat_fut => { unreachable!() }
             _ = overview_fut => { unreachable!() }
             _ = local_comm_fut => { unreachable!() }
@@ -227,7 +224,6 @@ pub async fn run_worker(
             Err(e) => {
                 // Server has disconnected
                 tokio::select! {
-                    //_ = &mut try_start_tasks => { unreachable!() }
                     r = finish_tasks_on_server_lost(state_ref.clone()) => r
                 }
                 Err(e)

crates/tako/src/internal/worker/rpc.rs

@@ -37,7 +37,6 @@ pub struct WorkerState {
     /// If `Some`, forcefully overrides `configuration.overview_configuration.send_interval`.
     pub(crate) worker_overview_interval_override: Option<Duration>,
     pub(crate) task_launcher: Box<dyn TaskLauncher>,
-    //pub(crate) secret_key: Option<Arc<SecretKey>>,
     pub(crate) start_time: Instant,
 
     pub(crate) lc_state: RefCell<LocalCommState>,
@@ -252,7 +251,6 @@ impl WorkerStateRef {
         let resource_label_map = ResourceLabelMap::new(&configuration.resources, &resource_map);
         let allocator =
             ResourceAllocator::new(&configuration.resources, &resource_map, &resource_label_map);
-        //let ready_task_queue = ResourceWaitQueue::new(allocator);
         let now = Instant::now();
 
         let state = Self::wrap(WorkerState {