Skip to content

fix: guard total_cached_tokens against None in Gemini metrics #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sumleo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: guard total_cached_tokens against None in Gemini metrics #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ii_agent/agents/models/google/interactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@ def _get_metrics(self, response_usage: Usage) -> Metrics:
metrics.reasoning_tokens = response_usage.total_thought_tokens or 0
metrics.total_tokens = response_usage.total_tokens

metrics.cache_read_tokens = response_usage.total_cached_tokens
metrics.cache_read_tokens = response_usage.total_cached_tokens or 0
# raw metrics
metrics.additional_metrics = response_usage.model_dump()
return metrics
4 changes: 4 additions & 0 deletions src/tests/unit/engine/test_v1_models_google_interactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,10 @@ def test_cache_read_tokens(self):
gi = _make_gi()
assert gi._get_metrics(_make_usage(cached_t=30)).cache_read_tokens == 30

def test_cache_read_tokens_none(self):
gi = _make_gi()
assert gi._get_metrics(_make_usage(cached_t=None)).cache_read_tokens == 0

def test_additional_metrics_populated(self):
gi = _make_gi()
assert gi._get_metrics(_make_usage()).additional_metrics is not None
Expand Down