Support SYCL source compilation by ndgrigorian · Pull Request #2206 · IntelPython/dpctl

ndgrigorian · 2025-11-30T09:18:13Z

This PR adds support for creating an executable kernel_bundle from SYCL source code to dpctl using the kernel_compiler DPC++ extension

Supersedes gh-2049

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2025-11-30T09:46:43Z

View rendered docs @ https://intelpython.github.io/dpctl/pulls/2206/index.html

github-actions · 2025-11-30T09:54:54Z

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_65 ran successfully.
Passed: 1111
Failed: 47
Skipped: 82

coveralls · 2025-11-30T09:55:21Z

coverage: 75.719% (+0.3%) from 75.39% — feature/sycl-source-compilation into master

github-actions · 2025-12-03T21:07:49Z

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_66 ran successfully.
Passed: 1115
Failed: 43
Skipped: 82

github-actions · 2025-12-17T21:49:26Z

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_104 ran successfully.
Passed: 1114
Failed: 44
Skipped: 82

Enable SYCL source compilation, but only for DPC++ versions that actually support the compilation, based on the __SYCL_COMPILER_VERSION reported. Uses the correct naming for the property based on DPC++ version, detected through C++ type traits to check which property actually refers to a fully defined type. This commit also works around a bug in DPC++ version 2025.1. The constructor with no parameter of class `include_files` was only declared, but never defined. Calling it when creating a SYCL source kernel bundle therefore leads to references to undefined symbols with DPC++ version 2025.1. This change works around this issue by calling an alternative constructor, which is defined in the release. Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>

vlad-perevezentsev · 2026-06-05T10:46:18Z

+                :class:`.SyclKernelBundle` is going to be built.
+            source (unicode)
+                SYCL source code string.
+            headers (list)


According to the description below, it should be headers (list, optional), right?

vlad-perevezentsev · 2026-06-05T10:46:27Z

+                documentation of the ``registered_names`` property in the DPC++
+                ``kernel_compiler`` extension for more information.
+                Default: []
+            copts (list)


vlad-perevezentsev · 2026-06-05T10:51:11Z

+    cdef bytes bContent
+    cdef const char* sContent
+    cdef const char* buildLogContent
+    for opt in copts:


This fails when copts is None (the default value)

dpctl.program.create_kernel_bundle_from_sycl_source(q, sycl_source) # out : TypeError: 'NoneType' object is not iterable.

Since this is repeated in the loops below, it make sense to add something like:

if copts is None: copts = [] if registered_names is None: registered_names = [] if headers is None: headers = []

vlad-perevezentsev · 2026-06-05T10:51:19Z

+        DPCTLBuildOptionList_Append(BuildOpts, sOpt)
+
+    cdef DPCTLKernelNameListRef KernelNames = DPCTLKernelNameList_Create()
+    for name in registered_names:


vlad-perevezentsev · 2026-06-05T10:51:25Z

+    cdef DPCTLVirtualHeaderListRef VirtualHeaders
+    VirtualHeaders = DPCTLVirtualHeaderList_Create()
+
+    for name, content in headers:


vlad-perevezentsev · 2026-06-05T11:06:13Z

+    __dpctl_keep const DPCTLSyclContextRef Ctx,
+    __dpctl_keep const DPCTLSyclDeviceRef Dev,
+    __dpctl_keep const char *Source,
+    __dpctl_keep DPCTLVirtualHeaderListRef Headers,
+    __dpctl_keep DPCTLKernelNameListRef Names,
+    __dpctl_keep DPCTLBuildOptionListRef BuildOptions,
+    __dpctl_keep DPCTLKernelBuildLogRef BuildLog)


Can any of these parameters be nullptr?
If so , should we add a nullptr check below?

vlad-perevezentsev · 2026-06-05T11:28:16Z

+    DPCTLBuildOptionList_Delete(BuildOpts)
+    DPCTLKernelNameList_Delete(KernelNames)
+    DPCTLVirtualHeaderList_Delete(VirtualHeaders)
+    DPCTLKernelBuildLog_Delete(BuildLog)
+


This may leak if an unexpected exception is raised earlier

vlad-perevezentsev · 2026-06-05T11:30:58Z


    create_kernel_bundle_from_source
    create_kernel_bundle_from_spirv
+    create_kernel_bundle_from_sycl_source


is_sycl_source_compilation_available is missing

vlad-perevezentsev · 2026-06-05T11:33:54Z

+                Optional list of kernel names to register. See the
+                documentation of the ``registered_names`` property in the DPC++
+                ``kernel_compiler`` extension for more information.
+                Default: []


The default value is None

ndgrigorian requested review from antonwolfy and vlad-perevezentsev as code owners November 30, 2025 09:18

ndgrigorian mentioned this pull request Dec 3, 2025

Support compilation from SYCL source code #2049

Closed

8 tasks

ndgrigorian force-pushed the feature/sycl-source-compilation branch from 9d64cb8 to 22475d9 Compare December 17, 2025 21:13

ndgrigorian force-pushed the feature/sycl-source-compilation branch 2 times, most recently from 75969ce to be75a7e Compare February 11, 2026 22:44

ndgrigorian force-pushed the feature/sycl-source-compilation branch from cf56032 to 7a58ef7 Compare February 17, 2026 02:13

ndgrigorian force-pushed the feature/sycl-source-compilation branch from 43d385b to 788fdd2 Compare April 8, 2026 09:12

ndgrigorian changed the base branch from master to feature/uncouple-tensor-from-dpctl April 8, 2026 09:13

ndgrigorian force-pushed the feature/sycl-source-compilation branch from 788fdd2 to 4656feb Compare April 8, 2026 09:39

ndgrigorian force-pushed the feature/uncouple-tensor-from-dpctl branch 2 times, most recently from b610ee3 to dd74214 Compare April 13, 2026 16:47

Base automatically changed from feature/uncouple-tensor-from-dpctl to master April 13, 2026 20:20

ndgrigorian force-pushed the feature/sycl-source-compilation branch from 4656feb to cae6959 Compare April 28, 2026 21:01

ndgrigorian force-pushed the feature/sycl-source-compilation branch 2 times, most recently from cfe7f1f to 417c4a0 Compare May 26, 2026 15:16

sommerlukas and others added 6 commits May 26, 2026 08:19

adds utility to dpctl.program

3b9321e

adds tests for SYCL source compilation

c521084

add bool DPCTLKernelBundle_CreateFromSYCLSource_Available to header

0f40fa0

add SYCL source creation function to __all__

9e0b72a

add create_kernel_bundle_from_sycl_source to docs

ece9fa0

ndgrigorian force-pushed the feature/sycl-source-compilation branch from 417c4a0 to ece9fa0 Compare May 26, 2026 15:26

run SYCL source compilation tests on Level Zero if possible

8d662b5

vlad-perevezentsev reviewed Jun 5, 2026

View reviewed changes

Conversation

ndgrigorian commented Nov 30, 2025

Uh oh!

github-actions Bot commented Nov 30, 2025

Uh oh!

github-actions Bot commented Nov 30, 2025

Uh oh!

coveralls commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 3, 2025

Uh oh!

github-actions Bot commented Dec 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Nov 30, 2025 •

edited

Loading