Skip to content

feat: add marimo-python chart#313

Open
PACordonnier wants to merge 2 commits into
InseeFrLab:mainfrom
adaltas:inseepr-light
Open

feat: add marimo-python chart#313
PACordonnier wants to merge 2 commits into
InseeFrLab:mainfrom
adaltas:inseepr-light

Conversation

@PACordonnier
Copy link
Copy Markdown

Description of the change

The PR aims to add Marimo as python env exclusively. It is a subset of PR #312.

I've made a more readable commit history. A commit having the change from vscode-python to marimo-python exists (67643b7) and is meant to highlight the changes made from vscode to marimo.

(Following text is copied from #312)

Changes:

  • in Chart.yaml
    • change name, description and other metadatas, set version to 0.0.1
  • README.md
    • delete its content, to be created by CI
  • values.schema.yaml
    • set the image name from inseefrlab/vscode-(xxx) to pacordonnier/marimo-(xxx)
  • values.yaml
    • set image version
    • set networking.service.port to 2718 (default marimo port)
  • templates folder:

Marimo does not support reading token/password from ENV, so needs to mount the secret-token as volumes

In statefulset.yaml, args are now:

{{- if .Values.git.asCodeServerRoot }}
args: ["{{ .Values.init.standardInitPath }} marimo edit --host 0.0.0.0 --token-password-file ~/.token/PASSWORD /home/{{ .Values.environment.user }}/work/$(basename $GIT_REPOSITORY) .git"]
{{- else }}
args: ["{{ .Values.init.standardInitPath }} marimo edit --host 0.0.0.0 --token-password-file ~/.token/PASSWORD /home/{{ .Values.environment.user }}/work"]
{{- end }}

volume for secret token needs to be declared in statefulset.yaml

spec.template.spec.volumes:
        - name: token
          secret:
            secretName: {{ include "library-chart.secretNameToken" . }}

volumeMounts:

spec.template.spec.containers[0].volumesMounts
- name: token  
  mountPath: /home/{{ .Values.environment.user }}/.token
   readOnly: true

Checklist

  • Chart version bumped in Chart.yaml
  • Title of the pull request follows this pattern [name_of_the_chart] Descriptive title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant