-
Notifications
You must be signed in to change notification settings - Fork 24
Update molecular inorganics bond handling (GHI # 218) #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nnuk
wants to merge
9
commits into
dev
Choose a base branch
from
MI-bond_handling
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+448
−12
Open
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c393082
Update molecular inorganics bond handling (GHI # 218)
nnuk 1032a20
Merge branch 'dev' into MI-bond_handling
nnuk 4d37db2
Update molecular inorganics unit test with GHI # 218
nnuk d0f9d55
Update MI preprocessing check with helper function
nnuk c15d53f
fix: treat MOLfile VAL as valence value for coordinative-bond donors
fbaensch-beilstein c55c3a4
Add unit tests
nnuk d1becd3
fix: convert coordinative bonds to single bonds and cancel paired cha…
fbaensch-beilstein 8e98baf
Add unit test for MI bond handling
nnuk fff0172
Fix for charged atom with just single bond
nnuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.