Change velocity unit of trj files to ang/ps - #1250
Merged
Merged
Conversation
MBartkowiakSTFC
force-pushed
the
velocity-unit-forcite
branch
from
June 30, 2026 07:53
f1798a6 to
06ed5b9
Compare
oerc0122
approved these changes
Jul 6, 2026
oerc0122
left a comment
oerc0122
left a comment
Collaborator
There was a problem hiding this comment.
If this fixes the issue, looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Assumes that velocity in trj files (e.g. from Forcite) is given in units of Ang/ps. This seems to work file for the trajectories of water and nylon from MDANSE-Examples.
Closes #1249
Fixes
To test
Calculate the temperature of water or nylon from the example trajectories. It should be less than 500K.