Urb 3568 Add dossier abandonne event #9
Open
WBoudabous wants to merge 3 commits into
Open
Conversation
WBoudabous
changed the title
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR adds a dossier-abandonne import path for the urban.events default profile, registers a 1005→1006 upgrade step, updates related migration logic, and adds the corresponding profile content, ordering manifests, and release note entry. ChangesDossier abandonne import
Sequence Diagram(s)sequenceDiagram
participant UpgradeStep as urban.events:default
participant Migration as install_dossier_abandonne_event
participant Configs as utils.get_configs
participant Importer as utils.import_all_config
UpgradeStep->>Migration: run upgrade step 1005 to 1006
Migration->>Configs: check "liege"
alt "liege" is absent
Migration->>Importer: import codt_uniquelicence, envclassone, envclasstwo with ExistingContent.UPDATE
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
WBoudabous
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/urban/events/migrations.py (1)
100-100: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueLog message understates scope. The function imports
codt_uniquelicence,envclassone, andenvclasstwo, but the start log only mentionscodt_uniquelicence. Align the message for accurate upgrade logs.📝 Suggested wording
- logger.info("starting : Import dossier abandonne event for codt_uniquelicence") + logger.info( + "starting : Import dossier abandonne event for codt_uniquelicence, envclassone and envclasstwo" + )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/urban/events/migrations.py` at line 100, The startup log in the migration import flow is too narrow and only mentions codt_uniquelicence, even though the same function also imports envclassone and envclasstwo. Update the logger.info message in the migration function that handles these event imports so it reflects the full scope of the import work, using the existing migration/import symbol names to keep the message accurate and consistent for upgrade logs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@news/URB-3568.feature`:
- Line 1: Update the release note text to use clear, properly separated wording
for the dossier abandonné event and correct the spelling/accent. Replace the
current phrasing in the note with a polished sentence that mentions CODT, unique
licence, envclassone, and envclasstwo as distinct items, and ensure “abandonné”
is accented correctly.
---
Nitpick comments:
In `@src/urban/events/migrations.py`:
- Line 100: The startup log in the migration import flow is too narrow and only
mentions codt_uniquelicence, even though the same function also imports
envclassone and envclasstwo. Update the logger.info message in the migration
function that handles these event imports so it reflects the full scope of the
import work, using the existing migration/import symbol names to keep the
message accurate and consistent for upgrade logs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f5c2a7de-1d6a-4801-8f11-ecd28d890295
📒 Files selected for processing (10)
news/URB-3568.featuresrc/urban/events/configure.zcmlsrc/urban/events/migrations.pysrc/urban/events/profiles/config/standard/codt_uniquelicence/codt_uniquelicence.jsonsrc/urban/events/profiles/config/standard/codt_uniquelicence/codt_uniquelicence_ordering.jsonsrc/urban/events/profiles/config/standard/envclassone/envclassone.jsonsrc/urban/events/profiles/config/standard/envclassone/envclassone_ordering.jsonsrc/urban/events/profiles/config/standard/envclasstwo/envclasstwo.jsonsrc/urban/events/profiles/config/standard/envclasstwo/envclasstwo_ordering.jsonsrc/urban/events/profiles/default/metadata.xml
| @@ -0,0 +1,2 @@ | |||
| Add dossier abandonne event for codt uniquelicence envclassone and envclasstwo | |||
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Polish release note wording for clarity.
Current sentence has formatting/wording issues (uniquelicence envclassone, missing separators, missing accent in “abandonné”).
Suggested text
-Add dossier abandonne event for codt uniquelicence envclassone and envclasstwo
+Add dossier abandonné event for codt_uniquelicence, envclassone, and envclasstwo.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Add dossier abandonne event for codt uniquelicence envclassone and envclasstwo | |
| Add dossier abandonné event for codt_uniquelicence, envclassone, and envclasstwo. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@news/URB-3568.feature` at line 1, Update the release note text to use clear,
properly separated wording for the dossier abandonné event and correct the
spelling/accent. Replace the current phrasing in the note with a polished
sentence that mentions CODT, unique licence, envclassone, and envclasstwo as
distinct items, and ensure “abandonné” is accented correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the configuration for the dossier abandonné event for CODT Unique Licence, envClassOne, and envClassTwo.
It is related to IMIO/Products.urban#587
Summary by CodeRabbit