URB-3640: implement pm ep courrier commune notification by WBoudabous · Pull Request #570 · IMIO/Products.urban

WBoudabous · 2026-06-01T07:10:00Z

This PR implements notification handling for PM_EP_COURRIER_COMMUNE

Summary by CodeRabbit

New Features
- Added support for the new public inquiry notification type PM_EP_COURRIER_COMMUNE across modified-plans workflows.
- Updated transfer workflows to accept this notification type for dates, tickets, and opinions.
Bug Fixes
- Fixed notice routing so PM_EP_COURRIER_COMMUNE is handled by the amended-plans workflow.
Documentation
- Added French translation text for PM_EP_COURRIER_COMMUNE in the UI language resources.
- Added a short release/news entry covering PM_EP_COURRIER_COMMUNE handling (with attribution).

coderabbitai · 2026-06-01T07:10:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4260e462-fbe2-4322-a9e1-2c3c3a043a75

📥 Commits

Reviewing files that changed from the base of the PR and between 6f3b6aa and 0a9e239.

📒 Files selected for processing (6)

news/URB-3640.feature
src/Products/urban/browser/cron/notice.py
src/Products/urban/browser/urbaneventviews.py
src/Products/urban/locales/fr/LC_MESSAGES/urban.po
src/Products/urban/locales/urban-manual.pot
src/Products/urban/locales/urban.pot

✅ Files skipped from review due to trivial changes (3)

news/URB-3640.feature
src/Products/urban/locales/urban.pot
src/Products/urban/locales/fr/LC_MESSAGES/urban.po

🚧 Files skipped from review as they are similar to previous changes (2)

src/Products/urban/locales/urban-manual.pot
src/Products/urban/browser/urbaneventviews.py

📝 Walkthrough

Walkthrough

This pull request adds support for the PM_EP_COURRIER_COMMUNE notice type across notice handling, transfer views, and localization files.

Changes

Notice Type Feature Enablement

Layer / File(s)	Summary
Cron notice handling updates `src/Products/urban/browser/cron/notice.py`	`notice.py` updates the amended-plans handler selection for `PM_EP_COURRIER_COMMUNE` and reformats notice import logging, error reporting, parcel/address mapping, and fallback descriptions without changing the surrounding control flow.
GÉSPER transfer view acceptance `src/Products/urban/browser/urbaneventviews.py`	Three GÉSPER EP transfer views add `PM_EP_COURRIER_COMMUNE` to their accepted incoming notice types.
Feature text and translations `news/URB-3640.feature`, `src/Products/urban/locales/fr/LC_MESSAGES/urban.po`, `src/Products/urban/locales/urban-manual.pot`, `src/Products/urban/locales/urban.pot`	The changelog entry and gettext catalog files add the `PM_EP_COURRIER_COMMUNE` message and French translation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

IMIO/Products.urban#567: Updates the same notification-routing and transfer-view acceptance paths in notice.py and urbaneventviews.py for other notice types.

Suggested reviewers

mpeeters

Poem

A new notice hops through the gate, 🐰
Views and cron now recognize its state,
French words bloom bright and clear,
PM_EP_COURRIER_COMMUNE is here!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 26.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding PM_EP_COURRIER_COMMUNE notification handling.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch URB-3640_implement_PM_EP_COURRIER_COMMUNE_notification

_{Comment @coderabbitai help to get the list of available commands.}

mpeeters

Can you fix the conflict ?

mpeeters

Please fix the comments

mpeeters · 2026-06-22T10:25:10Z

            "DEMANDE_AVIS_FACULTATIF_PLAN_MODIFIE_1_ERE_INSTANCE",
            "DEMANDE_ENQUETE_PUBLIQUE_PLAN_MODIFIE_1_ERE_INSTANCE",
-            "DEMANDE_ANNONCE_PROJET_PLAN_MODIFIE_1_ERE_INSTANCE",
+            "DEMANDE_ANNONCE PROJET_PLAN_MODIFIE_1_ERE_INSTANCE",


There is a withspace in the code, please remove it

There is still a whitespace in the code.

mpeeters · 2026-06-23T13:49:38Z

            "DEMANDE_AVIS_FACULTATIF_PLAN_MODIFIE_1_ERE_INSTANCE",
            "DEMANDE_ENQUETE_PUBLIQUE_PLAN_MODIFIE_1_ERE_INSTANCE",
-            "DEMANDE_ANNONCE_PROJET_PLAN_MODIFIE_1_ERE_INSTANCE",
+            "DEMANDE_ANNONCE PROJET_PLAN_MODIFIE_1_ERE_INSTANCE",


There is still a whitespace in the code.

mpeeters · 2026-06-25T13:12:33Z

                    failed_notice_id, exc, retry=True
                )
                logger.exception(
-                    u"%s",


Must remain unicode

mpeeters · 2026-06-25T13:12:48Z

                savepoint.rollback()
                custom_exc = ErrorProcessingNotificationException(notice_id, exc)
                logger.exception(
-                    u"%s",


Must remain unicode

mpeeters · 2026-06-25T13:13:03Z

        except Exception as exc:
            custom_exc = FailedGettingRecentNotificationsException(exc)
            logger.exception(
-                u"%s",


Must remain unicode

mpeeters · 2026-06-25T13:13:46Z

-            u"<p>${msg} for informations: ${data}</p>",
+            "<p>${msg} for informations: ${data}</p>",
            mapping={
                "msg": msg,
-                "data": u", ".join(
-                    [u"{0}: {1}".format(k, v) for k, v in serialized_data.items()]


Must remain unicode

mpeeters · 2026-06-25T13:15:01Z

                self.event.setDecision(urban_decision_term)
            else:
                self.event.setDescription(
-                    u"Décision: {}".format(self.notification.decision_code)


Must remain unicode

mpeeters · 2026-06-25T13:15:12Z

                self.event.setDecision(urban_decision_term)
            else:
-                self.event.setDescription(
-                    u"Décision: {}".format(decision_code)


Must remain unicode

WBoudabous requested a review from mpeeters June 4, 2026 12:32

mpeeters approved these changes Jun 22, 2026

View reviewed changes

WBoudabous force-pushed the URB-3640_implement_PM_EP_COURRIER_COMMUNE_notification branch from 7391aa7 to 591781a Compare June 22, 2026 10:12

mpeeters changed the title ~~Urb 3640 implement pm ep courrier commune notification~~ URB-364:0 implement pm ep courrier commune notification Jun 22, 2026

mpeeters requested changes Jun 22, 2026

View reviewed changes

mpeeters changed the title ~~URB-364:0 implement pm ep courrier commune notification~~ URB-3640: implement pm ep courrier commune notification Jun 22, 2026

WBoudabous requested a review from mpeeters June 22, 2026 13:09

mpeeters requested changes Jun 23, 2026

View reviewed changes

WBoudabous added 5 commits June 24, 2026 09:46

Handle PM_EP_COURRIER_COMMUNE_notification

4bc76f4

add translate

40b8b60

add changlog

736c978

Apply review comments

e81f2e3

Apply review comments

0a9e239

WBoudabous force-pushed the URB-3640_implement_PM_EP_COURRIER_COMMUNE_notification branch from 6f3b6aa to 0a9e239 Compare June 24, 2026 07:51

WBoudabous requested a review from mpeeters June 24, 2026 07:52

mpeeters requested changes Jun 25, 2026

View reviewed changes

Uh oh!

Conversation

WBoudabous commented Jun 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

mpeeters left a comment

Choose a reason for hiding this comment

Uh oh!

mpeeters left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

WBoudabous commented Jun 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 1, 2026 •

edited

Loading