Skip to content

SUP-51436 toggle field visibility #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WBoudabous wants to merge 2 commits into
base: 2.9.x
Choose a base branch
from
Open

SUP-51436 toggle field visibility #548

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ebe581
toggle field visibility
WBoudabous Apr 17, 2026
cde7b21
updates
WBoudabous Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ Changelog

2.9.17 (2026-04-10)
-------------------
New features:

-Add option to show or hide the representativeContacts field
[WBoudabous] (SUP-51436)

@coderabbitai coderabbitai Bot Apr 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n docs/CHANGES.rst | head -50

Repository: IMIO/Products.urban

Length of output: 1223

🏁 Script executed:

head -20 docs/CHANGES.rst

Repository: IMIO/Products.urban

Length of output: 515

🏁 Script executed:

find . -type d -name "news*" -o -type d -name "changelog*" 2>/dev/null | head -20

Repository: IMIO/Products.urban

Length of output: 69

🏁 Script executed:

fd -type f -name "pyproject.toml" -o -name "setup.cfg" -o -name "towncrier.toml" | head -5

Repository: IMIO/Products.urban

Length of output: 233

🏁 Script executed:

ls -la news/ | head -20

Repository: IMIO/Products.urban

Length of output: 228

🏁 Script executed:

find . -name "pyproject.toml" -o -name "setup.cfg" -o -name "towncrier.toml" | xargs grep -l "towncrier" 2>/dev/null

Repository: IMIO/Products.urban

Length of output: 79

🏁 Script executed:

cat pyproject.toml | grep -A 20 "towncrier"

Repository: IMIO/Products.urban

Length of output: 646

Entry should not be directly added to docs/CHANGES.rst; create a news fragment instead.

This project uses towncrier for changelog management. Per the instructions in the file, new entries should not be added directly to docs/CHANGES.rst. Instead, create a news fragment file in the news/ directory named something like SUP-51436.feature containing:

Add option to show or hide the representativeContacts field [WBoudabous]

Then towncrier will automatically regenerate the changelog during the next release process. Remove the entry from lines 13-16 of docs/CHANGES.rst.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@docs/CHANGES.rst` around lines 13 - 16, Remove the direct entry from
docs/CHANGES.rst (the "Add option to show or hide the representativeContacts
field [WBoudabous] (SUP-51436)" line) and instead create a towncrier news
fragment file named SUP-51436.feature under the news/ directory containing the
single line: "Add option to show or hide the representativeContacts field
[WBoudabous]". Ensure the CHANGES.rst entry is deleted so towncrier can
regenerate the changelog from the new fragment.


Bug fixes:

Expand Down
2 changes: 2 additions & 0 deletions src/Products/urban/content/licence/BaseBuildLicence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
"availableParkings",
"missingParkings",
"parkingDetails",
"representativeContacts",
]

slave_fields_habitation = (
Expand Down Expand Up @@ -515,6 +516,7 @@
),
popup_name="contact_reference_popup",
),
optional=True,
schemata="urban_description",
multiValued=1,
relationship="basebuildlicenceRepresentativeContacts",
Expand Down